draft: disable portal canonical-factory check (zone-009 Moderato regenesis)#708
Draft
Zygimantass wants to merge 1 commit into
Draft
draft: disable portal canonical-factory check (zone-009 Moderato regenesis)#708Zygimantass wants to merge 1 commit into
Zygimantass wants to merge 1 commit into
Conversation
…esis The TIP-1091 protocol-managed ZoneFactory (0x5aF2...0000) does not exist on Moderato (or any live chain) yet, so ZonePortal.initialize can never succeed there: the factory that deploys the portal is not at the canonical address and initialize reverts NotFactory. This draft disables the msg.sender check so a freshly deployed ZoneFactory can create and initialize portals on Moderato, unblocking the zone-009 regenesis (withdrawals are stuck on a portal that predates the processWithdrawal ABI change). Not intended to merge as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE as-is.
The TIP-1091 protocol-managed ZoneFactory (
0x5aF2...0000) does not exist on Moderato (no genesis alloc, no node precompile), so since #625ZonePortal.initializerevertsNotFactoryfor any freshly deployed factory — zone creation is currently impossible on Moderato.This draft comments out the
msg.sendercheck so a freshZoneFactorycan deploy + initialize portals there. Used only to build a one-offtempo-zone-xtask/tempo-zoneimage pair for the zone-009 regenesis (its portal predates theprocessWithdrawalABI change, wedging withdrawals — see theWithdrawal processing cycle failedloop in the sequencer logs).Once an L1 exposes the canonical factory (genesis-installed or via hardfork), zone regenesis goes through the normal path and this branch is obsolete.