-
Notifications
You must be signed in to change notification settings - Fork 26
feat: zones can restrict deposit/withdrawal and callback targets #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
0xalpharush
wants to merge
5
commits into
agent/closed-loop-membership-config
Choose a base branch
from
codex/open-loop-zones-e2e
base: agent/closed-loop-membership-config
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c0be6fd
feat: support explicit open-loop zones
0xalpharush 721143b
feat: make zone enforcement modes mutable
0xalpharush 64c1cd4
fix: allow empty closed-zone membership
0xalpharush 73a782b
fix: emit initial zone enforcement state
0xalpharush 75d011e
docs: move closed-loop fee FIXME
0xalpharush File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| //! `ZoneConfig` — Zone L2 system contract (0x1c00...0003). | ||
| crate::sol! { | ||
| #[derive(Debug)] | ||
| contract ZoneConfig { | ||
| function accessMode() external view returns (uint8); | ||
| function gatewayMode() external view returns (uint8); | ||
| function isAllowedAccount(address account) external view returns (bool); | ||
| function isZoneGateway(address gateway) external view returns (bool); | ||
| function isEnabledToken(address token) external view returns (bool); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The local ABI now sends expanded
CreateZoneParamsto the fixed TIP-1091 factory address, but the protocol factory is a native Tempo precompile. The pinned/available native implementation still exposes the old selector/metadata and initializes a portal storage mirror that stops before the new mode and membership slots. Calls against the old native ABI fail, and a partial runtime-only rollout can leave requested Closed/Enforced zones initialized as zero-slot Open/Open.Recommended Fix: Coordinate an atomic Tempo protocol update for native factory ABI/dispatch,
ZoneCreated/zones()encoding,verifier()/messenger(), overlap validation, and slots 19-21 initialization; gate old Moderato defaults until that target is live.