Skip to content

Fix Samsung floating window layout flicker #5090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xJonathanLEI wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −0
Open

Fix Samsung floating window layout flicker #5090

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions app/src/main/java/com/termux/app/terminal/TermuxActivityRootView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,26 @@ public void onGlobalLayout() {

FrameLayout.LayoutParams params = (FrameLayout.LayoutParams) getLayoutParams();

boolean isInMultiWindowMode = android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.N &&
mActivity.isInMultiWindowMode();

// The keyboard overlap workaround below relies on adjusting the activity root view's bottom
// margin after comparing the bottom spacer against the visible window frame. In Samsung
// floating window mode those measurements can oscillate by a row causing a rapid layout loop.
// Multi-window/floating containers already resize the app bounds themselves, so skip the
// workaround there.
if (isInMultiWindowMode) {
if (params.bottomMargin != 0) {
if (root_view_logging_enabled)
Logger.logVerbose(LOG_TAG, "Resetting bottom margin in multi-window mode");
params.setMargins(0, 0, 0, 0);
setLayoutParams(params);
}
marginBottom = null;
lastMarginBottom = null;
return;
}

// Get the position Rects of the bottom space view and the main window holding it
Rect[] windowAndViewRects = ViewUtils.getWindowAndViewRects(bottomSpaceView, mStatusBarHeight);
if (windowAndViewRects == null)
Expand Down