add_option_static#137
Merged
Merged
Conversation
tezc
reviewed
May 16, 2026
tezc
reviewed
May 16, 2026
Owner
|
@yanzixiang sorry, it took a while till I can have a look at this. I added a couple of minor comments, could you take a look? Thank you for the PR! |
tezc
approved these changes
Jun 2, 2026
Owner
|
@yanzixiang thank you for the PR and your patience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add compile option build code as static libraries (default shared)
add_option_static
maybe somebody like me needs it.