Repository navigation
fix(scan): "File all" printed raw inflect markup, and showed through the keyboard - #207
Merged
Merged
Conversation
…the keyboard Two bugs from #205, both found on device in 1.0.6 (46): - The dialog title read "File all ^[2 card](inflect: true) in…". That markup only resolves inside Text; a confirmationDialog title is a plain String and prints it raw (the same trap GroupDetailView's cardCount comment warns about). "File all" only appears with 2+ drafts, so a plain "\(n) cards" is always right. - The bottom-bar button showed through the keyboard's glass while the New divider alert's text field was up. It's now hidden while that alert is showing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Two UI bugs in "File all" (#205), found on device in TestFlight 1.0.6 (46):
^[…](inflect: true)only resolves insideText, and aconfirmationDialogtitle is a plainString(the same trapGroupDetailView.cardCountdocuments). The button only appears with 2+ cards, so a plain "File all (n) cards in…" is always correct.Checklist
.env, keys, ordocs/contents committedstaging🤖 Generated with Claude Code