Repository navigation
Conversation
The catalog keeps one weekly series per card: PPT's `priceHistory.conditions`, which is the primary printing's history (byte-identical to `priceHistory.variants[primaryPrinting]`, checked on Sceptile 2026-10-06). On a multi-printing card, the menu and the % badge follow the selected printing, but the chart didn't. A reverse holo up 400% was drawn as a flat holofoil line, and the caption blamed PPT for a limitation that turns out not to exist. The caption now names the chart's printing (`price_latest.raw_printing`, the same pick). When that isn't the selected printing, it says so outright. `raw_printing` is trusted only when it names one of the card's own priced printings; older artifacts filled it from a TCGdex-derived label, so anything else reads "the card's main printing". Per-printing history itself is the follow-up: the nightly already receives it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What you saw. A reverse holo shows a big % change, but the chart under it is flat. The chart was always the card's primary printing (usually Holofoil or Normal), while the menu and the % badge follow the printing you picked. The old caption said "PPT has no per-printing history", and that's wrong: we confirmed today that PPT does send it.
This change (for 1.0.6, build 48) only changes the label:
price_latest.raw_printing, PPT's primary printing.Follow-up (1.0.7): real per-printing charts. The nightly already receives
priceHistory.variants[printing]in the same call; that's the pipeline branch next.Tests:
ChartPrintingNoteis a static, tested helper, with 4 new cases inCardDetailRoutingTests. The full iOS suite ran 1298 tests with 0 failures.🤖 Generated with Claude Code