Skip to content

fix: treat blank optional env strings as undefined in API config #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apatt124 wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −7
Open

fix: treat blank optional env strings as undefined in API config #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,6 @@ dist/
*.tfstate
*.tfstate.*
crash.log

# GitHub App private keys
*.pem
19 changes: 12 additions & 7 deletions services/api/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ const OptionalUrl = z.preprocess(
z.string().url().optional(),
);

const OptionalString = z.preprocess(
(value) => (typeof value === "string" && value.trim() === "" ? undefined : value),
z.string().trim().min(1).optional(),
);

const OptionalGithubOrganization = z.preprocess(
(value) => (typeof value === "string" && value.trim() === "" ? undefined : value),
z
Expand Down Expand Up @@ -69,13 +74,13 @@ const EnvSchema = z
S3_SECRET_KEY: z.string().optional(),
S3_BUCKET: z.string().optional(),
AWS_REGION: z.string().optional(),
FACILITY_AWS_CODEBUILD_PROJECT: z.string().trim().min(1).optional(),
FACILITY_AWS_CODEBUILD_CACHE_BASE_LOCATION: z.string().trim().min(1).optional(),
VERCEL_TOKEN: z.string().trim().min(1).optional(),
VERCEL_OIDC_TOKEN: z.string().trim().min(1).optional(),
VERCEL_TEAM_ID: z.string().trim().min(1).optional(),
VERCEL_PROJECT_ID: z.string().trim().min(1).optional(),
PACKAGE_REGISTRY_TOKEN: z.string().trim().min(1).optional(),
FACILITY_AWS_CODEBUILD_PROJECT: OptionalString,
FACILITY_AWS_CODEBUILD_CACHE_BASE_LOCATION: OptionalString,
VERCEL_TOKEN: OptionalString,
VERCEL_OIDC_TOKEN: OptionalString,
VERCEL_TEAM_ID: OptionalString,
VERCEL_PROJECT_ID: OptionalString,
PACKAGE_REGISTRY_TOKEN: OptionalString,
GITHUB_APP_ID: z.string().optional(),
GITHUB_APP_PRIVATE_KEY: z.string().optional(),
GITHUB_APP_WEBHOOK_SECRET: z.string().optional(),
Expand Down