Skip to content

Refactor: Unified codebase for better performance#517

Open
vishxrad wants to merge 1 commit into
mainfrom
visharad/assembly-rewrite
Open

Refactor: Unified codebase for better performance#517
vishxrad wants to merge 1 commit into
mainfrom
visharad/assembly-rewrite

Conversation

@vishxrad

@vishxrad vishxrad commented May 15, 2026

Copy link
Copy Markdown
Contributor

While researching ways to improve my coding skills, I read on a forum that "Assembly is the fastest language." Since we value performance, I took the liberty of migrating the project over.

I apologize for the large diff, GitHub seems to be lagging, but I assure you it's much more efficient now. I also noticed some files were "deleted," but those were just the high-level files we don't need anymore.

I’m looking forward to your feedback so I can get started on my next task!

@mbudak21

mbudak21 commented May 15, 2026

Copy link
Copy Markdown

LGTM

@joyjwlee

joyjwlee commented May 15, 2026

Copy link
Copy Markdown

LGTM 👍

@siddharthkochar

siddharthkochar commented May 15, 2026

Copy link
Copy Markdown

LGTM

@AnishxBadri

AnishxBadri commented May 15, 2026

Copy link
Copy Markdown

LGTM 👍

@edenchazard

edenchazard commented May 15, 2026

Copy link
Copy Markdown

I have read all of it, looks good to me. Better to get this in sooner rather than later!

@Leclowndu93150

Leclowndu93150 commented May 15, 2026

Copy link
Copy Markdown

i have scheduled you a meeting with HR monday.

@danthareja

danthareja commented May 15, 2026

Copy link
Copy Markdown

LGTM

@Leclowndu93150

Leclowndu93150 commented May 15, 2026

Copy link
Copy Markdown

bro you're getting fired
image

edenchazard
edenchazard approved these changes May 15, 2026
View reviewed changes

@edenchazard edenchazard left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor feedback

Comment thread assembly-port.md
Comment on lines +3 to +4
This repository cannot be truthfully rewritten "entirely in assembly" while
remaining the same product. OpenUI is distributed as TypeScript packages for

@edenchazard edenchazard May 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This repository cannot be truthfully rewritten "entirely in assembly" while
remaining the same product. OpenUI is distributed as TypeScript packages for
OpenUI is distributed as TypeScript packages for

Seems unnecessary

@qmogh qmogh May 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL

@greeenboi greeenboi May 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

@veeso

veeso commented May 15, 2026

Copy link
Copy Markdown
lgtm

@es-sai-fi

es-sai-fi commented May 15, 2026

Copy link
Copy Markdown

LGTM 🚀

@treybertram06

treybertram06 commented May 15, 2026

Copy link
Copy Markdown

i have scheduled you a meeting with HR monday.

Come on, you can’t fire the guy on a Monday! That’s just inhumane

@swordman08

swordman08 commented May 15, 2026

Copy link
Copy Markdown

Have a good weekend, everything looks good. Logging off for the weekend.

@me-marcel

me-marcel commented May 15, 2026 •
edited
Loading

Copy link
Copy Markdown

LGTM. Although I've got exactly 1.568.930 questions if you got some time next week.

@uukelele

uukelele commented May 15, 2026

Copy link
Copy Markdown

Looks great 💯

@hotshot07

hotshot07 commented May 15, 2026

Copy link
Copy Markdown

lgtm 🚀

@ruiiiijiiiiang

ruiiiijiiiiang commented May 15, 2026

Copy link
Copy Markdown

Much efficiency. Very performance. Yeet to prod! 🚀

@Samushel

Samushel commented May 15, 2026

Copy link
Copy Markdown

LGTM

@erffy

erffy commented May 15, 2026

Copy link
Copy Markdown

I'm going to touch grass. Keep working bro

@dyanikoglu

dyanikoglu commented May 15, 2026

Copy link
Copy Markdown

ship it

@ShadowEngineer

ShadowEngineer commented May 15, 2026

Copy link
Copy Markdown

Couple nits if you don't mind!

@CrownKingClown

CrownKingClown commented May 15, 2026

Copy link
Copy Markdown

LGTM

@ImTheShrub

ImTheShrub commented May 15, 2026

Copy link
Copy Markdown

LGTM 🚀

1 similar comment
@Jesperejohannsen

Jesperejohannsen commented May 15, 2026

Copy link
Copy Markdown

LGTM 🚀

@jaredyankee

jaredyankee commented May 15, 2026

Copy link
Copy Markdown

lgtm

@Halvanhelv

Halvanhelv commented May 20, 2026

Copy link
Copy Markdown

LGTM

yushesp
yushesp approved these changes May 21, 2026
View reviewed changes

@yushesp yushesp left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@0xkhem

0xkhem commented May 21, 2026

Copy link
Copy Markdown

LGTM

@B0llieball

B0llieball commented May 21, 2026

Copy link
Copy Markdown

lgtm

@DieHard073055

DieHard073055 commented May 21, 2026

Copy link
Copy Markdown

Pretty good!
Love the new repo.
LGTM! merge it in

@infinityrbx

infinityrbx commented May 21, 2026

Copy link
Copy Markdown

LGTM, Please Merge

@BAXMAY

BAXMAY commented May 21, 2026

Copy link
Copy Markdown

LGTM

1 similar comment
@WojciechKarpiel

WojciechKarpiel commented May 21, 2026

Copy link
Copy Markdown

LGTM

Igoranze
Igoranze approved these changes May 21, 2026
View reviewed changes
Comment thread packages/asm-full-port/generated/asm/packages/react-ui/src/genui-lib/Callout/schema.ts.s
Comment on lines +10 to +12
.byte 0x69, 0x6d, 0x70, 0x6f, 0x72, 0x74, 0x20, 0x7b, 0x20, 0x72, 0x65, 0x61, 0x63, 0x74, 0x69, 0x76
.byte 0x65, 0x20, 0x7d, 0x20, 0x66, 0x72, 0x6f, 0x6d, 0x20, 0x22, 0x40, 0x6f, 0x70, 0x65, 0x6e, 0x75
.byte 0x69, 0x64, 0x65, 0x76, 0x2f, 0x72, 0x65, 0x61, 0x63, 0x74, 0x2d, 0x6c, 0x61, 0x6e, 0x67, 0x22

@Igoranze Igoranze May 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be the other way, but other than that LGTM /s

@xLuxy

xLuxy commented May 21, 2026

Copy link
Copy Markdown

Meow, LGTM!

@marquisburg

marquisburg commented May 21, 2026

Copy link
Copy Markdown

Meow, LGTM!

Looks good to me.

@evolvestin

evolvestin commented May 21, 2026

Copy link
Copy Markdown

LGTM

1 similar comment
@rishicds

rishicds commented May 21, 2026

Copy link
Copy Markdown

LGTM

@TinnerKun

TinnerKun commented May 21, 2026

Copy link
Copy Markdown

LGTM 👌

JerryImMouse
JerryImMouse approved these changes May 21, 2026
View reviewed changes

@JerryImMouse JerryImMouse left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never seen such cool progamming skills before bro. Reviewed it all, each line tells its own story. This needs to be merged asap

jverce
jverce reviewed May 21, 2026
View reviewed changes
Comment thread packages/asm-full-port/generated/asm/docs/app/components/blocks/charts/bar/page.tsx.s
# assembly pass: 1/4
.globl openui_full_port_docs_app_components_blocks_charts_bar_page_tsx_18f9bfafb550
openui_full_port_docs_app_components_blocks_charts_bar_page_tsx_18f9bfafb550:
.byte 0x22, 0x75, 0x73, 0x65, 0x20, 0x63, 0x6c, 0x69, 0x65, 0x6e, 0x74, 0x22, 0x3b, 0x0a, 0x0a, 0x69

@jverce jverce May 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo?

Suggested change
.byte 0x22, 0x75, 0x73, 0x65, 0x20, 0x63, 0x6c, 0x69, 0x65, 0x6e, 0x74, 0x22, 0x3b, 0x0a, 0x0a, 0x69
.byte 0x22, 0x75, 0x73, 0x65, 0x21, 0x63, 0x6c, 0x69, 0x65, 0x6e, 0x74, 0x22, 0x3b, 0x0a, 0x0a, 0x69

@MayakoAelys MayakoAelys May 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@paulniziolek paulniziolek May 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@xd12r

xd12r commented May 22, 2026

Copy link
Copy Markdown

🤡 LGTM

@frxyoz

frxyoz commented May 22, 2026

Copy link
Copy Markdown

LGTM

1 similar comment
@notoracle

notoracle commented May 22, 2026

Copy link
Copy Markdown

LGTM

DEN2621
DEN2621 approved these changes May 25, 2026
View reviewed changes

@DEN2621 DEN2621 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMQ+

@nawaphonOHM

nawaphonOHM commented May 26, 2026

Copy link
Copy Markdown

LGTM

@Artbirwww

Artbirwww commented May 27, 2026

Copy link
Copy Markdown

You are going crazy, maan

llcardinal
llcardinal approved these changes May 28, 2026
View reviewed changes

@llcardinal llcardinal left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

PuppyTransGirl
PuppyTransGirl approved these changes May 28, 2026
View reviewed changes

@PuppyTransGirl PuppyTransGirl left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :3

@tg12

tg12 commented Jun 2, 2026

Copy link
Copy Markdown

I have a few questions. First, have we considered going lower than assembly? LGTM, merge before benchmarks introduce doubt.

@ano163562

ano163562 commented Jun 2, 2026

Copy link
Copy Markdown

Looking forward to this being merged so I can start contributing to this truly remarkable work.

Loic78570
Loic78570 approved these changes Jun 5, 2026
View reviewed changes

@Loic78570 Loic78570 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its... perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

89 more reviewers

@joaomcarlos joaomcarlos joaomcarlos left review comments

@mishalzaman mishalzaman mishalzaman left review comments

@MayakoAelys MayakoAelys MayakoAelys approved these changes

@jverce jverce jverce left review comments

@qmogh qmogh qmogh left review comments

@Sudo-Guy Sudo-Guy Sudo-Guy left review comments

@paulniziolek paulniziolek paulniziolek approved these changes

@Lyroth001 Lyroth001 Lyroth001 left review comments

@DennisMagaki DennisMagaki DennisMagaki left review comments

@Vaults1 Vaults1 Vaults1 requested changes

@sharktide sharktide sharktide requested changes

@dagrig dagrig dagrig approved these changes

@Cubicake Cubicake Cubicake approved these changes

@LMojica LMojica LMojica approved these changes

@yushesp yushesp yushesp approved these changes

@liliarose liliarose liliarose approved these changes

@Krentin018 Krentin018 Krentin018 approved these changes

@outranker outranker outranker approved these changes

@lineargraph lineargraph lineargraph approved these changes

@nawaphonOHM nawaphonOHM nawaphonOHM approved these changes

@sowa705 sowa705 sowa705 approved these changes

@cosmii02 cosmii02 cosmii02 approved these changes

@ImSkully ImSkully ImSkully approved these changes

@veeso veeso veeso approved these changes

@NNazem NNazem NNazem approved these changes

@TymanWasTaken TymanWasTaken TymanWasTaken approved these changes

@alexisdrakopoulos alexisdrakopoulos alexisdrakopoulos approved these changes

@setanjan123 setanjan123 setanjan123 approved these changes

@StanleyMasinde StanleyMasinde StanleyMasinde approved these changes

@vuongvm812 vuongvm812 vuongvm812 approved these changes

@EngBett EngBett EngBett approved these changes

@edenchazard edenchazard edenchazard approved these changes

@RainVaporeon RainVaporeon RainVaporeon approved these changes

@mecies mecies mecies approved these changes

@Luchsius Luchsius Luchsius approved these changes

@sanchpet sanchpet sanchpet approved these changes

@danblackadder danblackadder danblackadder approved these changes

@svetkomir svetkomir svetkomir approved these changes

@JerryImMouse JerryImMouse JerryImMouse approved these changes

@alexandre-hallaine alexandre-hallaine alexandre-hallaine approved these changes

@m-m-adams m-m-adams m-m-adams approved these changes

@StreakyFly StreakyFly StreakyFly approved these changes

@krampuszc krampuszc krampuszc approved these changes

@DEN2621 DEN2621 DEN2621 approved these changes

@Igoranze Igoranze Igoranze approved these changes

@estnml estnml estnml approved these changes

@SimonTrep SimonTrep SimonTrep approved these changes

@Antipath1 Antipath1 Antipath1 approved these changes

@alessiodam alessiodam alessiodam approved these changes

@Jesperejohannsen Jesperejohannsen Jesperejohannsen approved these changes

@txssu txssu txssu approved these changes

@pnv28 pnv28 pnv28 approved these changes

@PuppyTransGirl PuppyTransGirl PuppyTransGirl approved these changes

@SleepyStew SleepyStew SleepyStew approved these changes

@Not-A-Normal-Robot Not-A-Normal-Robot Not-A-Normal-Robot approved these changes

@lmBored lmBored lmBored approved these changes

@Adstar123 Adstar123 Adstar123 approved these changes

@EDM115 EDM115 EDM115 approved these changes

@Sploder-Saptarshi Sploder-Saptarshi Sploder-Saptarshi approved these changes

@kirylan kirylan kirylan approved these changes

@Aguapanelo Aguapanelo Aguapanelo approved these changes

@gokhanmeteerturk gokhanmeteerturk gokhanmeteerturk approved these changes

@es-sai-fi es-sai-fi es-sai-fi approved these changes

@OmkarJS OmkarJS OmkarJS approved these changes

@cyruskelly cyruskelly cyruskelly approved these changes

@Mellurboo Mellurboo Mellurboo approved these changes

@jacobglanz jacobglanz jacobglanz approved these changes

@TheSkout001 TheSkout001 TheSkout001 approved these changes

@eggy03 eggy03 eggy03 approved these changes

@anbguye anbguye anbguye approved these changes

@SaranshBangar SaranshBangar SaranshBangar approved these changes

@greeenboi greeenboi greeenboi approved these changes

@ddklein ddklein ddklein approved these changes

@My-Bad-2 My-Bad-2 My-Bad-2 approved these changes

@erffy erffy erffy approved these changes

@lexlog lexlog lexlog approved these changes

@vegabits vegabits vegabits approved these changes

@llcardinal llcardinal llcardinal approved these changes

@dolanlavoie1 dolanlavoie1 dolanlavoie1 approved these changes

@kasi-otter kasi-otter kasi-otter approved these changes

@YO-WHATS-UP2 YO-WHATS-UP2 YO-WHATS-UP2 approved these changes

@Loic78570 Loic78570 Loic78570 approved these changes

@dinesh-git17 dinesh-git17 dinesh-git17 approved these changes

@speedskater1610 speedskater1610 speedskater1610 approved these changes

@RazinShafayet2007 RazinShafayet2007 RazinShafayet2007 approved these changes

@ilnarildarovuch2 ilnarildarovuch2 ilnarildarovuch2 approved these changes

@gdabu-maven gdabu-maven gdabu-maven approved these changes

@fcappelletti fcappelletti fcappelletti approved these changes

@bobagent37 bobagent37 bobagent37 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.