Skip to content

build(ci)!: move the solidity toolchain to Node 24 #4205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mswilkison wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −19
Open

build(ci)!: move the solidity toolchain to Node 24 #4205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/contracts-ecdsa.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
# Using fixed version, because 18.16 was sometimes causing issues with
# artifacts generation during `hardhat compile` - see
# https://github.com/NomicFoundation/hardhat/issues/3877
node-version: "22.23.1"
node-version: "24.11.1"

- uses: ./.github/actions/install-yarn-deps
with:
Expand All @@ -81,7 +81,7 @@ jobs:
# Using fixed version, because 18.16 was sometimes causing issues with
# artifacts generation during `hardhat compile` - see
# https://github.com/NomicFoundation/hardhat/issues/3877
node-version: "22.23.1"
node-version: "24.11.1"

- uses: actions/setup-python@v4
with:
Expand Down Expand Up @@ -123,7 +123,7 @@ jobs:
# Using fixed version, because 18.16 was sometimes causing issues with
# artifacts generation during `hardhat compile` - see
# https://github.com/NomicFoundation/hardhat/issues/3877
node-version: "22.23.1"
node-version: "24.11.1"

- uses: ./.github/actions/install-yarn-deps
with:
Expand All @@ -150,7 +150,7 @@ jobs:
# Using fixed version, because 18.16 was sometimes causing issues with
# artifacts generation during `hardhat compile` - see
# https://github.com/NomicFoundation/hardhat/issues/3877
node-version: "22.23.1"
node-version: "24.11.1"

- uses: ./.github/actions/install-yarn-deps
with:
Expand Down Expand Up @@ -183,7 +183,7 @@ jobs:
# Using fixed version, because 18.16 was sometimes causing issues with
# artifacts generation during `hardhat compile` - see
# https://github.com/NomicFoundation/hardhat/issues/3877
node-version: "22.23.1"
node-version: "24.11.1"
registry-url: "https://registry.npmjs.org"

- uses: ./.github/actions/install-yarn-deps
Expand Down Expand Up @@ -283,7 +283,7 @@ jobs:
# Using fixed version, because 18.16 was sometimes causing issues with
# artifacts generation during `hardhat compile` - see
# https://github.com/NomicFoundation/hardhat/issues/3877
node-version: "22.23.1"
node-version: "24.11.1"
registry-url: "https://registry.npmjs.org"

- uses: ./.github/actions/install-yarn-deps
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/contracts-random-beacon.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
# Using fixed version, because 18.16 was sometimes causing issues with
# artifacts generation during `hardhat compile` - see
# https://github.com/NomicFoundation/hardhat/issues/3877
node-version: "22.23.1"
node-version: "24.11.1"

- uses: ./.github/actions/install-yarn-deps
with:
Expand All @@ -81,7 +81,7 @@ jobs:
# Using fixed version, because 18.16 was sometimes causing issues with
# artifacts generation during `hardhat compile` - see
# https://github.com/NomicFoundation/hardhat/issues/3877
node-version: "22.23.1"
node-version: "24.11.1"

- uses: actions/setup-python@v4
with:
Expand Down Expand Up @@ -121,7 +121,7 @@ jobs:
# Using fixed version, because 18.16 was sometimes causing issues with
# artifacts generation during `hardhat compile` - see
# https://github.com/NomicFoundation/hardhat/issues/3877
node-version: "22.23.1"
node-version: "24.11.1"

- uses: ./.github/actions/install-yarn-deps
with:
Expand All @@ -148,7 +148,7 @@ jobs:
# Using fixed version, because 18.16 was sometimes causing issues with
# artifacts generation during `hardhat compile` - see
# https://github.com/NomicFoundation/hardhat/issues/3877
node-version: "22.23.1"
node-version: "24.11.1"

- uses: ./.github/actions/install-yarn-deps
with:
Expand Down Expand Up @@ -181,7 +181,7 @@ jobs:
# Using fixed version, because 18.16 was sometimes causing issues with
# artifacts generation during `hardhat compile` - see
# https://github.com/NomicFoundation/hardhat/issues/3877
node-version: "22.23.1"
node-version: "24.11.1"
registry-url: "https://registry.npmjs.org"

- uses: ./.github/actions/install-yarn-deps
Expand Down Expand Up @@ -279,7 +279,7 @@ jobs:
# Using fixed version, because 18.16 was sometimes causing issues with
# artifacts generation during `hardhat compile` - see
# https://github.com/NomicFoundation/hardhat/issues/3877
node-version: "22.23.1"
node-version: "24.11.1"
registry-url: "https://registry.npmjs.org"

- uses: ./.github/actions/install-yarn-deps
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/npm-ecdsa.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
# Using fixed version, because 18.16 may cause issues with the
# artifacts generation during `hardhat compile` - see
# https://github.com/NomicFoundation/hardhat/issues/3877.
node-version: "22.23.1"
node-version: "24.11.1"
registry-url: "https://registry.npmjs.org"

- uses: ./.github/actions/install-yarn-deps
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/npm-random-beacon.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
# Using fixed version, because 18.16 may cause issues with the
# artifacts generation during `hardhat compile` - see
# https://github.com/NomicFoundation/hardhat/issues/3877.
node-version: "22.23.1"
node-version: "24.11.1"
registry-url: "https://registry.npmjs.org"

- uses: ./.github/actions/setup-git-for-yarn
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-solidity-docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: "22.23.1"
node-version: "24.11.1"

- uses: ./.github/actions/install-yarn-deps
with:
Expand Down
2 changes: 1 addition & 1 deletion solidity/ecdsa/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:22.23.1-alpine
FROM node:24.11.1-alpine

@coderabbitai coderabbitai Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

Use a non-root runtime user in both Hardhat images.

Both Dockerfiles omit USER, so their Hardhat entrypoints run as root. Chown $WORK_DIR after copying the project, then set USER node before the entrypoint.

  • solidity/ecdsa/Dockerfile#L1-L1: add the ownership change and USER node.
  • solidity/random-beacon/Dockerfile#L1-L1: add the same ownership change and USER node.
🧰 Tools
🪛 Trivy (0.72.0)

[error] 1-1: Image user should not be 'root'

Specify at least 1 USER command in Dockerfile with non-root user as argument

Rule: DS-0002

Learn more

(IaC/Dockerfile)

[error] 1-1: Image user should not be 'root'

Specify at least 1 USER command in Dockerfile with non-root user as argument

Rule: DS-0002

Learn more

(IaC/Dockerfile)

📍 Affects 2 files
  • solidity/ecdsa/Dockerfile#L1-L1 (this comment)
  • solidity/random-beacon/Dockerfile#L1-L1
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@solidity/ecdsa/Dockerfile` at line 1, Update both solidity/ecdsa/Dockerfile
lines 1-1 and solidity/random-beacon/Dockerfile lines 1-1: after copying the
project, change ownership of $WORK_DIR to the node user, then set USER node
before the Hardhat entrypoint so both images run non-root.

Source: Linters/SAST tools


RUN apk add --update --no-cache \
git \
Expand Down
2 changes: 1 addition & 1 deletion solidity/ecdsa/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
"@threshold-network/solidity-contracts": "1.3.0-dev.14"
},
"engines": {
"node": ">=22.0.0"
"node": ">=24.0.0"

@coderabbitai coderabbitai Bot Aug 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

Synchronize the lockfile with the new engine contract.

solidity/ecdsa/package-lock.json:53-55 still records "node": ">= 14.0.0", while this manifest requires >=24.0.0. Regenerate the tracked lockfile so npm tooling does not use conflicting runtime metadata.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@solidity/ecdsa/package.json` at line 81, Regenerate the tracked
package-lock.json for the solidity/ecdsa package using the updated package.json
engines declaration, ensuring its root metadata records Node >=24.0.0 instead of
>=14.0.0. Do not alter the manifest’s engine contract.

},
"resolutions": {
"ethereumjs-abi": "npm:0.6.8",
Expand Down
2 changes: 1 addition & 1 deletion solidity/random-beacon/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:22.23.1-alpine
FROM node:24.11.1-alpine

RUN apk add --update --no-cache \
git \
Expand Down
2 changes: 1 addition & 1 deletion solidity/random-beacon/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
"typescript": "^4.4.3"
},
"engines": {
"node": ">=22.0.0"
"node": ">=24.0.0"
},
"resolutions": {
"ethereumjs-abi": "npm:0.6.8"
Expand Down
Loading