[LOOP-5952 & LOOP-5953] Liquid Glass Fixes Part 2 - #946
Open
Camji55 wants to merge 1 commit into
Open
Conversation
Camji55
commented
Aug 16, 2026
Camji55
commented
Member
- https://tidepool.atlassian.net/browse/LOOP-5952
- https://tidepool.atlassian.net/browse/LOOP-5953
stachon
reviewed
Aug 17, 2026
| Text("mg/dL") | ||
| .foregroundColor(.secondary) | ||
| } | ||
| Text("mg/dL") |
There was a problem hiding this comment.
Should DisplayGlucosePreference be used for the unit?
stachon
reviewed
Aug 17, 2026
| private var actionButton: some View { | ||
| Button<Text>( | ||
| action: { | ||
| if self.viewModel.actionButtonAction == .enterBolus { |
| var saveFavoriteFoodButtonDisabled: Bool { | ||
| get { | ||
| if let carbsQuantity, 0...maxCarbEntryQuantity.doubleValue(for: preferredCarbUnit) ~= carbsQuantity, foodType != "", selectedFavoriteFoodIndex == -1 { | ||
| if let carbsQuantity, 0...maxCarbEntryQuantity.doubleValue(for: preferredCarbUnit) ~= carbsQuantity, effectiveFoodType != "", selectedFavoriteFoodIndex == -1 { |
There was a problem hiding this comment.
The selectedDefaultAbsorptionTimeEmoji always has value, so this now allows for empty foodType ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.