Fix error repro from invalid randomized diagnosis date. - #90
Merged
Conversation
ProfilePage: add a locator for the inline diagnosis-date error (anchored to .PatientInfo-blocks > div:nth-child(3)...) and two helper methods: waitForEditFields (ensure core edit fields are visible) and clickSave (click Save without waiting for the form to close to trigger inline validation). Test: import expect and update the claimed profile test to compute deterministic birth/diagnosis dates and a random notes string, verify the edit fields are visible, submit an invalid diagnosis date (earlier than birth) using clickSave, assert an inline validation error is shown, then correct the date to a valid value and save. These changes exercise the form's on-submit inline validation and the correction path. Note: the diagnosis error selector relies on the 3rd .PatientInfo-blocks child and should be updated if the form structure changes.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Adds deterministic diagnosis-date validation coverage to the claimed-patient profile workflow.
Changes:
- Exercises invalid and corrected diagnosis dates.
- Adds profile edit-form and save helpers.
- Adds an inline diagnosis-error locator.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tests/claimed/API-Profile/Claimed-EditProfileDetailsAccessConfirm.spec.ts |
Tests diagnosis-date rejection and correction. |
page-objects/patient/ProfilePage.ts |
Adds edit-form helpers and error locator. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| await test.step( | ||
| 'Then an inline validation error is shown for the diagnosis date', | ||
| async () => { | ||
| await expect(profilePage.diagnosisDateError).toHaveText(/\S/); |
Comment on lines
+30
to
+32
| this.diagnosisDateError = this.page.locator( | ||
| '.PatientInfo-blocks > div:nth-child(3) > div > div', | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProfilePage: add a locator for the inline diagnosis-date error (anchored to .PatientInfo-blocks > div:nth-child(3)...) and two helper methods: waitForEditFields (ensure core edit fields are visible) and clickSave (click Save without waiting for the form to close to trigger inline validation).
Test: import expect and update the claimed profile test to compute deterministic birth/diagnosis dates and a random notes string, verify the edit fields are visible, submit an invalid diagnosis date (earlier than birth) using clickSave, assert an inline validation error is shown, then correct the date to a valid value and save. These changes exercise the form's on-submit inline validation and the correction path. Note: the diagnosis error selector relies on the 3rd .PatientInfo-blocks child and should be updated if the form structure changes.