Add support for Accu-Chek meters and pumps using Smart Pix (UPLOAD-685, UPLOAD-872) - #1546
Merged
Conversation
gniezen
marked this pull request as ready for review
February 20, 2023 14:38
krystophv
reviewed
Feb 22, 2023
krystophv
left a comment
krystophv
left a comment
Member
There was a problem hiding this comment.
While stylistically fairly different than most of the codebase, this seems largely sound. I have a few questions/comments that I'd like to get a bit of feedback on before giving it the thumbs up.
krystophv
previously approved these changes
Feb 23, 2023
krystophv
left a comment
krystophv
left a comment
Member
There was a problem hiding this comment.
Post review updates LGTM 👍🏼
Contributor
|
The VCLA should be in order, see #1432 (comment). |
gniezen
force-pushed
the
Sensotrend-smartpix-on-tp-master
branch
from
October 17, 2023 13:50
efc80e8 to
cd31018
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continues the excellent work done by @mrinnetmaki and @jlaunonen in #1432 to add support for the Roche Accu-Chek Smart Pix device. It handles both meters and the Spirit/Combo pump.
I created a new PR as our CI/CD pipeline will not build binaries for external PRs, and I don't have permission to push to external PRs either.