Repository navigation
fix: omit empty value on SetOrganizationFeature requests - #151
Open
HusseinAdeiza wants to merge 1 commit into
Open
HusseinAdeiza wants to merge 1 commit into
HusseinAdeiza wants to merge 1 commit into
Conversation
The API spec lists value as required while its own description calls it
optional, so the generated struct tags it `json:"value"` and every
request sends `"value": ""`. Features that take no value reject that
with a 400:
invalid value for feature (FEATURE_NAME_OTP_EMAIL_AUTH): Some("")
MarshalJSON drops the field when Value is empty, leaving the public API
unchanged so existing callers keep passing a plain string. Fixes tkhq#150.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetOrganizationFeatureRequest.Valueis generated withoutomitempty, so every request sends"value": "", and features that take no value reject it with a 400.The spec is the source:
v1SetOrganizationFeatureIntentlistsvalueasrequiredwhile its own description says "Optional value for the feature". It is the only definition in the spec with that mismatch.I fixed it in
types_extensions.gorather than the vendored swagger, sincecodegen/inputs/public_api.swagger.jsonis synced from the API repo (chore: sync from mono) and an edit there would be reverted on the next sync.Valuestays a plainstringso existing callers are unaffected.The proper long-term fix is dropping
valuefromrequiredin the API spec, which makes the generator emitValue *stringon its own.Fixes #150