Skip to content

Added suppress warning option - #582

Open
EliusSolis wants to merge 4 commits into
tobac-project:RC_v1.6.xfrom
EliusSolis:add_suppress_warning_option
Open

EliusSolis wants to merge 4 commits into
tobac-project:RC_v1.6.xfrom
EliusSolis:add_suppress_warning_option

Conversation

@EliusSolis

Copy link
Copy Markdown

Resolves #558

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

@github-actions

github-actions Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

Linting results by Pylint:

Your code has been rated at 8.31/10 (previous run: 8.34/10, -0.03)
The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the RC_v1.6.x branch.
A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.

@codecov

codecov Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.05%. Comparing base (de3c098) to head (c235f5b).
⚠️ Report is 3 commits behind head on RC_v1.6.x.

Additional details and impacted files
@@            Coverage Diff             @@
##           RC_v1.6.x     #582   +/-   ##
==========================================
  Coverage      66.05%   66.05%           
==========================================
  Files             28       28           
  Lines           4251     4251           
==========================================
  Hits            2808     2808           
  Misses          1443     1443           
Flag Coverage Δ
unittests 66.05% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@w-k-jones
w-k-jones self-requested a review September 8, 2026 07:10

@w-k-jones w-k-jones left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @EliusSolis , thanks for your first contribution! Could you format the code using the black library, and add a test to make sure that the warning is issued when suppress_warnings=False and no warning when suppress_warnings=True. Thanks!

@freemansw1 freemansw1 modified the milestones: v1.6.5, v.1.6.4 Oct 9, 2026

@w-k-jones w-k-jones left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @EliusSolis thanks for these changes, I'm happy to merge this now. Thanks again for contributing!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants