FIX: (adoc-promote): headings get wrongfully turned into sub-type 2 - #4
Open
fapdash wants to merge 1 commit into
Open
FIX: (adoc-promote): headings get wrongfully turned into sub-type 2#4fapdash wants to merge 1 commit into
fapdash wants to merge 1 commit into
Conversation
If the heading contains whitespace or a newline after the heading title it gets turned into a sub-type 2 heading. - add failing tests - fix issue by throwing away whitespace in match group 3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the heading contains whitespace or a newline after the
heading title it gets turned into a sub-type 2 heading.
In theory we could change the regex but a comment indicates that some other logic depends on the newline being matched, but I didn't investigate further:
adoc-mode/adoc-mode.el
Lines 689 to 691 in c0906ff