Skip to content

ci: update prek hooks - #2

Open
github-actions[bot] wants to merge 1 commit into
mainfrom
prek-autoupdate
Open

ci: update prek hooks#2
github-actions[bot] wants to merge 1 commit into
mainfrom
prek-autoupdate

Conversation

@github-actions

@github-actions github-actions Bot commented Feb 9, 2026

Copy link
Copy Markdown

Automated prek hook version updates.

This PR was created by the prek autoupdate workflow.

tomz-alt pushed a commit that referenced this pull request Feb 11, 2026
feat: implement `StatePath`
@github-actions
github-actions Bot force-pushed the prek-autoupdate branch 2 times, most recently from 7c502e1 to a237c1d Compare February 23, 2026 01:15
@github-actions
github-actions Bot force-pushed the prek-autoupdate branch 2 times, most recently from c0516b2 to 94f1e8f Compare March 23, 2026 01:18
@github-actions
github-actions Bot force-pushed the prek-autoupdate branch from a789be8 to 57d4130 Compare May 4, 2026 01:56
@github-actions
github-actions Bot force-pushed the prek-autoupdate branch 2 times, most recently from 7537d3c to e3c2051 Compare June 8, 2026 02:40
tomz-alt pushed a commit that referenced this pull request Jun 22, 2026
…io#1999)

Resolves the spec's §4.2 observability gap: previously, orphan-delete
failures during a normal update's commit phase (when a parent's
`process()` no longer declared a child it had declared on a prior run)
hit the framework's default `error!` log instead of routing through the
parent's user-installed exception handler chain. Only `App.drop()` (a
Delete-mode root with a raising on_error) propagated descendant
failures; `coco.mount`-mounted parents had no observability.

Symmetric with `ComponentDeleteContext::on_error`:

- `ComponentBuildContext` gains an `on_error: Option<OnError>` field.
- `ComponentProcessingAction::new_build` and
  `new_processor_context_for_build` accept it.
- `Component::mount` stores its `on_error` argument on the child's Build
  context (in addition to passing it to `run_in_background`) — one
  handler, two surfaces.
- `LiveComponentController::update_full` and `run_op`'s `Op::Update`
  branch mirror the same pattern for the live-component dispatch path.
- `App::update` (root), `Component::use_mount` (foreground), and
  `mount_inner_live`'s synthetic parent context pass `None` — the prior
  log+swallow default is preserved where intentional.

`launch_child_component_gc` switches from `delete_action_on_error()` to
the new unified `processing_action_on_error()`, so it cascades the
parent's on_error regardless of mode. `delete_action_on_error()` stays
as the Delete-only accessor used by `Component::delete`'s spawned task
(a Build context's on_error is meant for cascades, not for invoking on
the build's own failure — that flows through `run_in_background`'s
`on_error` argument directly).

Adds `test_orphan_delete_failure_routes_through_parent_handler` in
test_exception_handlers.py: parent mounts child A on update #1, doesn't
mount A on update #2, sink fails during the orphan delete. Verifies
the handler fires exactly once (mount_kind="mount"). Toggling
`launch_child_component_gc` back to `delete_action_on_error()`
confirms the test fails without this change.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
@github-actions
github-actions Bot force-pushed the prek-autoupdate branch 2 times, most recently from 2394718 to 6dc22eb Compare July 6, 2026 02:10
@github-actions
github-actions Bot force-pushed the prek-autoupdate branch 2 times, most recently from c862563 to 0817d23 Compare August 3, 2026 01:52
@github-actions
github-actions Bot force-pushed the prek-autoupdate branch 2 times, most recently from 4a1a07b to e84ede3 Compare August 17, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant