Skip to content

Add Additional Targets to kermit-ktor #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samhill303 merged 3 commits into from
Apr 21, 2026
Merged

Add Additional Targets to kermit-ktor #477

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3948ff3
Add JVM and native targets to `kermit-ktor`
solcott Mar 31, 2026
910fa1e
Replace deprecated `publishAllLibraryVariants` with `publishLibraryVa…
solcott Mar 31, 2026
b0b447f
Publish release variants for Android targets
solcott Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/kermit-bugsnag/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ plugins {

kotlin {
androidTarget {
publishAllLibraryVariants()
publishLibraryVariants()

@samhill303 samhill303 Apr 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
publishLibraryVariants()
publishLibraryVariants("release")

Without an argument, it doesn't publish any variants (the kermit-ktor usage was already incorrect too)

@solcott solcott Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. I just pushed an update that fixes this.

}
macosX64()
macosArm64()
Expand Down
2 changes: 1 addition & 1 deletion extensions/kermit-crashlytics/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ plugins {

kotlin {
androidTarget {
publishAllLibraryVariants()
publishLibraryVariants()
}
macosX64()
macosArm64()
Expand Down
2 changes: 1 addition & 1 deletion extensions/kermit-koin/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ plugins {

kotlin {
androidTarget {
publishAllLibraryVariants()
publishLibraryVariants()
}
jvm()
js {
Expand Down
0 extensions/kermit-ktor/api/kermit-ktor.api → ...s/kermit-ktor/api/android/kermit-ktor.api
View file
Open in desktop
File renamed without changes.
7 changes: 7 additions & 0 deletions extensions/kermit-ktor/api/jvm/kermit-ktor.api
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
public final class co/touchlab/kermit/ktor/KermitKtorLogger : io/ktor/client/plugins/logging/Logger {
public fun <init> (Lco/touchlab/kermit/Severity;Lco/touchlab/kermit/Logger;)V
public fun <init> (Lco/touchlab/kermit/Severity;Lco/touchlab/kermit/LoggerConfig;Ljava/lang/String;)V
public synthetic fun <init> (Lco/touchlab/kermit/Severity;Lco/touchlab/kermit/LoggerConfig;Ljava/lang/String;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
public fun log (Ljava/lang/String;)V
}

10 changes: 10 additions & 0 deletions extensions/kermit-ktor/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ kotlin {
androidTarget {
publishLibraryVariants()
}
jvm()
macosX64()
macosArm64()
iosX64()
Expand All @@ -41,6 +42,15 @@ kotlin {
nodejs()
}

mingwX64()
linuxX64()
linuxArm64()

androidNativeArm32()
androidNativeArm64()
androidNativeX86()
androidNativeX64()

sourceSets {
commonMain.dependencies {
implementation(libs.ktor.logging)
Expand Down
2 changes: 1 addition & 1 deletion kermit-core/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ plugins {

kotlin {
androidTarget {
publishAllLibraryVariants()
publishLibraryVariants()
}
jvm()
js {
Expand Down
2 changes: 1 addition & 1 deletion kermit-io/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ plugins {

kotlin {
androidTarget {
publishAllLibraryVariants()
publishLibraryVariants()
}
jvm()

Expand Down
2 changes: 1 addition & 1 deletion kermit-test/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ plugins {

kotlin {
androidTarget {
publishAllLibraryVariants()
publishLibraryVariants()
}
jvm()
js {
Expand Down
2 changes: 1 addition & 1 deletion kermit/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ plugins {

kotlin {
androidTarget {
publishAllLibraryVariants()
publishLibraryVariants()
}
jvm()
js {
Expand Down