SmokeMe v3: split, modernize, explicit registration - #13
Merged
Conversation
- Split into 2 packages: SmokeMe (core, netstandard2.0) and SmokeMe.AspNetCore (net8.0/net9.0/net10.0) - New ISmokeTestConfiguration interface decouples from ASP.NET IConfiguration - Explicit registration: AddSmokeMe() + MapSmokeEndpoint() (Minimal APIs) - Legacy SmokeController kept with [Obsolete] for migration path - Removed deprecated ICheckSmoke interface - Replaced Newtonsoft.Json with System.Text.Json - Deleted Sample.dotnet5.Api (EOL), added Sample.Api with Minimal Hosting - Retargeted Sample.ExternalSmokeTests to netstandard2.0 - Updated CI workflow for .NET 8/9, actions v4 - All 27 tests pass Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ization consistency - Remove net10.0 from TFMs, target net8.0/net9.0 (supported versions) - Delete stale Sample.31.Api/ directory and Smoke.xml - Restore 30s timeout on RestClient HttpClient (netstandard2.0 compat) - Use Results.Json consistently in MapSmokeEndpoint (instead of Results.Ok) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add MIGRATION-v2-to-v3.md with step-by-step upgrade instructions - Rewrite README for v3: setup with AddSmokeMe()/MapSmokeEndpoint(), packages table, configuration section, updated FAQ - Update release notes in both csproj with migration guide link - Replace breakingChanges.jpg with breaking-news-v3.png - Replace Twitter icon/link with Bluesky (thomas.pierrain@shodo.io) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Absolute URLs pointed to wrong repo (42skillz/Smoke) or to main branch where the new images don't exist yet. Relative paths work on any branch. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Removes the branch restriction on push so that feature branches also produce NuGet artifacts. Also ignores .md and .png changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tpierrain
added a commit
that referenced
this pull request
Mar 30, 2026
Based on a LinkedIn discussion with Pierre Gillon about which features to smoke test and how to handle non-rollbackable features, external dependencies, service choreography and fake production data. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SmokeMe(core, netstandard2.0) andSmokeMe.AspNetCore(net8.0/net9.0/net10.0)ISmokeTestConfigurationinterface decouples from ASP.NET'sIConfigurationAddSmokeMe()+MapSmokeEndpoint()(Minimal APIs)SmokeControllerkept with[Obsolete]for migration pathICheckSmokeinterfaceSample.dotnet5.Api(EOL), addedSample.Apiwith Minimal HostingSample.ExternalSmokeTeststo netstandard2.0Test plan
dotnet build SmokeMe.sln— compiles all 5 projectsdotnet test SmokeMe.sln— 27/27 tests passdotnet pack— producesSmokeMe.3.0.0.nupkgandSmokeMe.AspNetCore.3.0.0.nupkgSample.Apiandcurl http://localhost:5000/smoketo verify end-to-end🤖 Generated with Claude Code