refactor(P3d): source data_format from the ModalityRegistry#257
Merged
Conversation
Fourth and final slice of P3 (backend#796). conventions._data_format_for was a 6-frozenset ladder (IMAGE / TEXT / TABULAR / TIME_SERIES / TIME_TO_EVENT / MLM); it now reads spec_for(category).data_format — the registry is the single source. Adds data_format to ModalitySpec. Behaviour-identical: the same DataFormat per category. test_conventions (including the per-category data_format tests) and test_template_equivalence (the #44 YAML-resolution acceptance gate) pass unchanged. Full suite 1035 passed, 97.3%. Also drops a now-unused DataFormat import and a PRE-EXISTING unused Intent import from conventions.py. Scope note: the conventions file-options DEFAULT_* dicts and the grouping frozensets (still used by _default_file_options_for + exported/tested) stay in conventions — folding those + the resolve() defaults fully into the registry is a follow-up (with P5's resolve cleanup). REGRESSION_CLASS_CATEGORIES is exported/tested only (not used in resolve logic), left as-is. Stacked on #256 (P3c). Completes the P3 series (a-d): the per-category dispatch — validators, transfer, behavior flags, and data_format — now has one source, the ModalityRegistry. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
Author
|
👋 Heads-up — Code review queue is at 17 / 8 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
This was referenced Jun 15, 2026
Merged
fix(label): strip whitespace from label values to prevent silent class duplication (issue #261)
#262
Merged
fix(dataset rm): delete staging files from a uid-65532 pod, not jobs-manager (#259)
tracebloc/cli#78
Open
divyasinghds
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth and final slice of P3 (epic backend#796).
conventions._data_format_forwas a 6-frozenset ladder; it now readsspec_for(category).data_format— the registry is the single source. Addsdata_formattoModalitySpec.Stacked on #256 (P3c).
Behaviour-identical: same DataFormat per category.
test_conventions(incl. per-category data_format tests) andtest_template_equivalence(the #44 acceptance gate) pass unchanged. Full suite 1035 passed, 97.3%. Also drops a now-unusedDataFormatimport + a pre-existing unusedIntentimport.Scope note: the file-options
DEFAULT_*dicts + grouping frozensets (still used by_default_file_options_for/ exported) stay in conventions — folding them fully into the registry is a follow-up with P5's resolve cleanup.Completes the P3 series (a–d): per-category dispatch — validators, transfer, flags, data_format — now has one source, the
ModalityRegistry.🤖 Generated with Claude Code