Skip to content

test(e2e): drop stale semantic_segmentation xfail — mask sidecar is wired (#136)#277

Open
LukasWodka wants to merge 1 commit into
developfrom
test/drop-semseg-xfail-136
Open

test(e2e): drop stale semantic_segmentation xfail — mask sidecar is wired (#136)#277
LukasWodka wants to merge 1 commit into
developfrom
test/drop-semseg-xfail-136

Conversation

@LukasWodka

Copy link
Copy Markdown
Collaborator

What

Removes the last xfail marker in the e2e ingestion suite — the
semantic_segmentation case (#136) — turning it into a normal passing case,
and refreshes e2e/README.md's now-stale "known gaps" section.

Why

The e2e harness marks each known gap xfail(strict=False) against its tracking
ticket; the file's own convention is that when the fix lands the test XPASSes
and the mark can be dropped
. The semseg case has been XPASSing — the
declarative mask-sidecar wiring shipped a while ago (mask_id preserved through
process_record, #212, plus the P3c transfer registry), and #136 is already
closed
. This PR just removes the leftover scaffolding.

Verification (real MySQL, declarative cli/run path)

  • Full e2e suite green: 24 passed. semantic_segmentation now reports
    PASSED (not xfail/xpass).
  • Controlled end-to-end check of the declarative path
    (cli/runmap_file_transfersemantic_segmentation transfer factory →
    mask_transfer):
    • 3 images + 3 masks staged into DEST_PATH; the masks are
      byte-identical (md5) to source — i.e. mask_transfer genuinely copied
      them (it is the only writer of DEST_PATH/*_mask.png).
    • 3 rows inserted with correct label / filename / extension;
      mask_id correctly absent as a DB column (popped before insert in
      _process_batch).
    • Negative control: with masks/ emptied, the run fails (rc=1, 0 rows, no
      masks staged) — proving mask staging is load-bearing, not coincidental.

Notes

🤖 Generated with Claude Code

…ired (#136)

The declarative path stages the per-row mask sidecar end-to-end:
cli/run -> map_file_transfer -> semantic_segmentation transfer factory ->
mask_transfer. mask_id is preserved through process_record (#212) and popped
before the DB insert; the mask lands in DEST_PATH alongside its image. The e2e
case had been XPASSing, which the suite's own convention says signals the fix
landed and the xfail can be removed.

Verified end-to-end against real MySQL: 3 images + 3 masks staged (byte-identical
copies), 3 rows inserted, mask_id absent from the table. A masks-removed negative
control fails the run, confirming mask staging is load-bearing.
Full e2e suite green (24 passed).

#136 was already closed (fix shipped via #212 + the P3c transfer registry); this
removes the leftover test scaffolding. Also refreshes e2e/README.md, whose
"known gaps (xfail)" table was stale for all three listed modalities (#135 / #137
were un-xfailed earlier).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@LukasWodka

Copy link
Copy Markdown
Collaborator Author

👋 Heads-up — Code review queue is at 13 / 8

Above the WIP limit. The team convention is to review existing PRs before opening new work.

Open PRs currently in Code review (oldest first):

Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant