Skip to content

test(#260): regression test — validator-rejected ingest creates no table#279

Merged
divyasinghds merged 1 commit into
developfrom
test/p260-orphaned-table-regression
Jun 17, 2026
Merged

test(#260): regression test — validator-rejected ingest creates no table#279
divyasinghds merged 1 commit into
developfrom
test/p260-orphaned-table-regression

Conversation

@LukasWodka

Copy link
Copy Markdown
Collaborator

Summary

#260 (orphaned table on validator rejection) is already fixed on developcreate_table was deferred out of __init__ to after validate_data passes (_table_schema stashed in __init__, table created in _ingest_with_lock). That fix shipped without the regression test its acceptance criteria called for. This adds it.

tests/test_ingest_atomicity.py pins the ordering:

Both pass on develop. Independent of the open P5 refactor stack (new file, no overlap).

Closes #260.

🤖 Generated with Claude Code

#260 (orphaned table on validator rejection) was fixed by deferring
create_table until after validate_data passes (table_schema is stashed in
__init__, the table created in _ingest_with_lock after validation). That fix
shipped without the regression test its acceptance criteria called for.

Adds tests/test_ingest_atomicity.py pinning the ordering:
- a validator-rejected ingest raises and leaves NO table
  (database.create_table is never called), so a rejected ingest is idempotent
  and doesn't block the next attempt with the stale-table guard;
- a clean validation still creates the table (the deferral didn't break the
  happy path).

Closes #260.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@LukasWodka

Copy link
Copy Markdown
Collaborator Author

👋 Heads-up — Code review queue is at 17 / 8

Above the WIP limit. The team convention is to review existing PRs before opening new work.

Open PRs currently in Code review (oldest first):

Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.)

@divyasinghds divyasinghds merged commit c4ec2e5 into develop Jun 17, 2026
6 checks passed
@divyasinghds divyasinghds deleted the test/p260-orphaned-table-regression branch June 17, 2026 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants