Remove ssh-key from "Upgrade examples" workflow - #2051
Open
smoelius wants to merge 1 commit into
Open
Conversation
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude-generated PR description follows.
Remove
ssh-keyfrom the "Upgrade examples" workflowRemoves
ssh-key: ${{ secrets.SSH_KEY }}from theactions/checkoutstep in.github/workflows/upgrade_examples.yml, and adds a comment abovetokenrecording whya PAT is used and what it must be granted.
Why
The workflow configured two credentials that address the same problem: pull requests
created with the default
GITHUB_TOKENdo not trigger further workflow runs. Theaction's docs list SSH deploy keys and a PAT as alternatives, and are explicit about
what each provides:
This repository has no
on: pushworkflow for branches.ci.ymltriggers onmerge_group,pull_request,schedule, andworkflow_dispatch;release.ymltriggers on
pushbut is restricted totags: v*, which anupgrade-examples-<random>branch does not match. The deploy key therefore has no effect on which workflows run.
REPO_TOKENis what causes the generated pull request to firepull_requestevents, soci.ymlruns on it. That matters here, because the point of the pull request is to findout whether the upgraded examples still build, as noted in
scripts/upgrade_examples.sh:Effect on the push
With
ssh-keyremoved,actions/checkoutleaves an HTTPS remote, andcreate-pull-requestpushes the branch usingbranch-token, whichdefaults to the value of
token— i.e.REPO_TOKEN. A classic PAT needsreposcope; a fine-grained PAT needscontents: writeandpull-requests: writepermissions.scripts/upgrade_examples.shuses only local git operations (git diff), so it does notdepend on the remote being SSH.