Describe deployment for the blueprint the gem now supports - #670
Merged
Conversation
The Heroku and Capistrano instructions were written when every EmberCLI application was a classic Broccoli build that installed Bower dependencies. An application generated with `ember-cli >= 6.8` has no `bower.json`, so its readers were told to configure a Bower executable that nothing runs and to link a `bower_components` directory that is never created. They were also left to guess whether Vite's development server — the visible difference between the two build systems — changes anything about a deploy. It does not: the development server only runs in `development`. Nothing said which NodeJS the build runs on either, though the buildpack takes it from the `package.json` the generator writes and falls back to the current LTS release when that file names no version, while the Vite-based blueprint requires NodeJS `>= 20.19.0`. Drop the steps that only ever applied to a Bower build, say what installs the dependencies today, and state the NodeJS requirement where each deployment target reads it. Also correct `asset:precompile` to the `assets:precompile` task the gem actually hooks. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014rAfkAVGVifbaEoTVeT66u
tricknotes
force-pushed
the
heroku-docs-vite-blueprint
branch
from
September 7, 2026 12:08
3f07474 to
742aeed
Compare
tricknotes
marked this pull request as ready for review
September 7, 2026 12:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation-only. Brings the Heroku and Capistrano instructions in line with the build system the gem now centers on.
Why
The deployment instructions were written when every EmberCLI application was a classic Broccoli build that installed Bower dependencies. An application generated with
ember-cli >= 6.8has nobower.json, so a reader following the README today is told to configure a Bower executable that nothing runs and to link abower_componentsdirectory that is never created.They were also left to guess whether Vite's development server — the visible difference between the two build systems — changes anything about a deploy. It does not:
App#buildonly starts the development server indevelopment(lib/ember_cli/app.rb), so production is identical for both blueprints.Nothing said which NodeJS the build runs on, either. Heroku's NodeJS buildpack reads
engines.nodefrom the project root'spackage.json— the filerails generate ember:herokuwrites — and builds on the current LTS release when that file names no version, while the Vite-based blueprint requires NodeJS>= 20.19.0.What changed
npm install, oryarn installfor ayarn-configured application); refreshed thenvm$PATHexample off NodeJSv4.2.1; droppedbower_componentsfrom thelinked_dirsexample.asset:precompiletoassets:precompile, the tasklib/tasks/ember-cli.rakeactually hooks.Notes
>= 1.13.13, soShell#installand the generatedpackage.json'sbowerdependency stay exactly as they are.package.json.heroku-generator-node-enginesmakes the generator writeengines.nodeitself; if that lands, this paragraph stays true and simply becomes a description of what the generator already did.Verification
No code changed, so nothing to run. Reviewed the rendered sections for correct anchors (
#vite-based-applications) and link definitions.🤖 Generated with Claude Code
https://claude.ai/code/session_014rAfkAVGVifbaEoTVeT66u