Describe the NodeJS pinning as the one change it is - #675
Merged
Conversation
`EmberCli::App#node_engine` had a CHANGELOG entry of its own, next to the entry for the pinning it exists to serve. It is not a separate decision for a reader to make — nothing asks them to call it — so listing it separately implied two changes where there is one. The surrounding sections already draw the line this way: `0.13.1` and `0.13.2` each describe one change in one entry while naming every method it touches, and `0.13.0` splits into entries only where each one asks the reader for a separate decision — enabling the development server, raising the `ember-cli-rails-assets` requirement, configuring `origin`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014rAfkAVGVifbaEoTVeT66u
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG wording only. Folds two entries from #674 into one.
Why
EmberCli::App#node_enginehad an entry of its own, next to the entry for theengines.nodepinning it exists to serve. It is not a separate decision for a reader to make — nothing asks them to call it — so listing it separately implied two changes where there is one.The surrounding sections already draw the line at "one entry per decision the reader makes", not per PR or per method:
0.13.1describes one change in one entry while naming bothEmberCli::App#testandEmberCli.test!.0.13.2does the same forEmberCli::BuildError,rake ember:compileandrake ember:install.0.13.0splits into three entries because each asks the reader for a separate decision — enable the development server, raise theember-cli-rails-assetsrequirement, configureorigin.What changed
node_enginestays named, so the new public method is still discoverable from the CHANGELOG.Out of scope
The other entries in the
mainsection stay separate. Removingrails_12factorfrom theGemfile, renamingApp#yarn_enabled?, and the NodeJS pinning all sit underrails generate ember:heroku, but each asks the reader for a different action — and folding them would bury the "To upgrade" note on the first one.Verification
Documentation only; no code changed.
🤖 Generated with Claude Code
https://claude.ai/code/session_014rAfkAVGVifbaEoTVeT66u
Generated by Claude Code