Conversation
This was referenced May 26, 2026
Member
Author
|
Closing this draft-created PR and reopening as a normal PR so the existing GitHub Actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: this is the Java companion canary for the API2 contract generator work. API2 owns the TUS protocol contract; this PR proves tus-java-client can consume generated protocol facts without duplicating wire knowledge in the Java repo.
What changed:
TusProtocol.DEFAULT_PROTOCOL_VERSIONfrom the API2 TUS wire contractTusClient.TUS_VERSIONfrom that generated constantsingleUploadLifecyclefeature consume the generated factsValidation:
./gradlew clean check --no-daemonapi2/bin/cli.ts contracts tus-sdks --no-motd --platform java --sdk-root ../tus-java-client --compare-existingCompanion PRs: