Feature/194 - #219
Conversation
|
Cool! Looks like it is hooked up correctly. I'm not sure what the definition of done here is since we don't have the other user-specific pages up. Is it OK, that there isn't any indicators of signing in? Maybe a GET/user to get your username and display it somewhere in the nav bar? I haven't done too much on the front end so I'd like someone else to approve/advise on this. |
frostyshadows
left a comment
frostyshadows
left a comment
There was a problem hiding this comment.
Tested it out and looks like all the calls are working :) left a few comments
| @@ -0,0 +1,12 @@ | |||
| const store = { | |||
There was a problem hiding this comment.
looks like this file appeared because of a Git issue, it should be safe to delete
| if (response === 200) { | ||
| responseHTML = 'Account successfully created'; | ||
| } else { | ||
| responseHTML = <font color='#ff0000'> {response} </font>; |
There was a problem hiding this comment.
I saw that you set color='blue' on a button in another part of the code, is it possible to do color='red' here?
| } | ||
| var encodedKey = encodeURIComponent(property); | ||
| var encodedValue = encodeURIComponent(details[property]); | ||
| formBody.push(encodedKey + '=' + encodedValue); |
There was a problem hiding this comment.
could use a string template here
3 participants
🔨 Changes
Connected signup/login forms to the backend. I have changed the name for the Username/email part of the login form to just email, since the backend doesn't support logging in using username.
:squirrel: Testing instructions
📄 Relevant screenshots or documentation links
📋 Checklist