Repository navigation
Allow admin revocation of API Keys - #1391
Open
k-burt-uch wants to merge 1 commit into
Open
k-burt-uch wants to merge 1 commit into
k-burt-uch wants to merge 1 commit into
Conversation
Coverage Report for CI Build 39494915305Coverage increased (+0.07%) to 75.813%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions10 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
k-burt-uch
force-pushed
the
fix/denylist-username
branch
from
October 20, 2026 20:46
977774f to
128ffca
Compare
k-burt-uch
force-pushed
the
fix/denylist-username
branch
from
October 20, 2026 20:46
128ffca to
95bc1a4
Compare
Integration Tests
Please find the detailed integration test report here Please find the Github Action logs here |
paulineribeyre
requested changes
Oct 21, 2026
Comment on lines
144
to
+149
| if not api_key: | ||
| flask.abort(404, "token not found with JTI {} for current user".format(jti)) | ||
| flask.abort(404, "token not found with JTI {}".format(jti)) | ||
|
|
||
| # Check if the admin can delete the token. | ||
| if str(api_key.userid) != user_id: | ||
| authz_authorize( |
Contributor
There was a problem hiding this comment.
If a user who is not an admin and not the key's owner tries to delete a key that does exist, i think this would return a 401 instead of a 404.
Can we return 404 in that case? And maybe add a lil test case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one:
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes