Skip to content

fix(clinical): detect duplicate schedules by SQL error number #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rlorenzo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(clinical): detect duplicate schedules by SQL error number #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions web/Areas/ClinicalScheduler/Services/ScheduleEditService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,12 +247,9 @@ await _auditService.LogPrimaryEvaluatorSetAsync(
_logger.LogError(saveEx, "Database save failed for MothraId='{MothraId}', RotationId={RotationId}, WeekIds=[{WeekIds}]",
LogSanitizer.SanitizeId(mothraId), rotationId, string.Join(",", weekIds));

// Check if this is a database constraint violation (typically a duplicate key error)
var errorMessage = saveEx.Message?.ToLower();
var innerMessage = saveEx.InnerException?.Message?.ToLower();

if ((errorMessage != null && (errorMessage.Contains("duplicate") || errorMessage.Contains("unique") || errorMessage.Contains("constraint") || errorMessage.Contains("violation of primary key"))) ||
(innerMessage != null && (innerMessage.Contains("duplicate") || innerMessage.Contains("unique") || innerMessage.Contains("constraint") || innerMessage.Contains("violation of primary key"))))
// Only a unique/duplicate-key violation means the instructor is already scheduled.
// Other DB errors (foreign-key, check constraints, etc.) fall through to the generic message.
if (IsDuplicateKeyViolation(saveEx))
{
throw new InvalidOperationException($"Instructor {mothraId} appears to already be scheduled for one or more of the specified weeks. Please refresh the page and try again.", saveEx);
}
Expand All @@ -262,6 +259,15 @@ await _auditService.LogPrimaryEvaluatorSetAsync(
}
}

// SQL Server: 2627 = unique constraint violation, 2601 = duplicate key in a unique index.
// EF wraps the provider error in DbUpdateException, so unwrap to the underlying SqlException.
private static bool IsDuplicateKeyViolation(Exception ex)
{
var sqlEx = ex as SqlException ?? ex.InnerException as SqlException;
return sqlEx is not null
&& sqlEx.Errors.Cast<SqlError>().Any(e => e.Number is 2627 or 2601);
}

public async Task<(bool success, bool wasPrimaryEvaluator, string? instructorName)> RemoveInstructorScheduleAsync(
int instructorScheduleId,
CancellationToken cancellationToken = default)
Expand Down
Loading