fix(extensions/selection): hide native selection while editor is blurred#7907
Open
ozdemircibaris wants to merge 1 commit into
Open
fix(extensions/selection): hide native selection while editor is blurred#7907ozdemircibaris wants to merge 1 commit into
ozdemircibaris wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 75e8404 The changes in this PR will be included in the next version bump. This PR includes changesets to release 73 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Overview
The
Selectionextension now hides the native browser selection while the editor is blurred, so only its styled.selectiondecoration is shown; previously a multi-line selection left the native highlight bleeding to the full width of each wrapped line, beyond the selected text.Implementation Approach
On editor creation the extension injects a small scoped stylesheet (via core's existing
createStyleTagutility, honoring the editor'sinjectCSS/injectNonceoptions) that makes::selectiontransparent on a blurred editor (.ProseMirror:not(.ProseMirror-focused)), mirroring core's existingProseMirror-hideselectionpattern.Testing Done
Added
packages/extensions/__tests__/selection.spec.tsasserting the stylesheet is injected (and skipped wheninjectCSS: false); lint, build, the extensions unit tests, and the existing Selection e2e on Chromium + Firefox all pass.Verification Steps
Open the Selection demo, select text spanning multiple lines, then blur the editor (e.g. focus another element); the highlight should hug only the selected text instead of filling the empty space at the end of each wrapped line.
Additional Notes
The React/Vue demos were updated to multi-line content and a multi-line selection so the behavior is visible; the suppression applies to any blurred ProseMirror editor on the page, matching core's global
ProseMirror-hideselectionapproach.AI Usage
Checklist
Related Issues
Closes #7006