fix: T-153-api-query-filter

[khalsz]

This fixes the filter bug. and this works perfectly compared to all other methods I have tried before. But removes previous page from api response.

[samueljackson92]

It doesn't look like the issue has been fixed. If I query the following

http://localhost:8081/json/shots?fields=shot_id

I get this response:

Which

1. Has removed all the entires from the context
2. Has loads of entries which are not shot_id in the items returned.

[khalsz]

It doesn't look like the issue has been fixed. If I query the following

http://localhost:8081/json/shots?fields=shot_id

I get this response:

Which

1. Has removed all the entires from the context
2. Has loads of entries which are not shot_id in the items returned.

Thank you for mentioning this.

1. I have fixed the problem of the empty context. Here is the result of the resolution:
   

2. Meanwhile, your question regarding loading of other entries. This is expected, because those entries and compulsory to be returned and they carry required args in the build up of the table (an example is context, even though context is not a shot_id field, it was returned because it is required. If those fields are not return for any reason, there will be error.

[samueljackson92]

Sorry, this still does not fix the issue for me.

When I run the query http://localhost:8081/json/shots?fields=shot_id,url

I get the following back:

Which clearly includes more fields than just shot_id and url.

Also, a unit test case should be added to cover this issue.

[khalsz]

I left fields @context, @type, title as a required field for all query.

[jameshod5]

Works for me with fields only returning what we are asking for, but maybe the names are a bit confusing

[jameshod5]

Maybe we should rename these classes, I assume BaseModel is what is returned when we use fields. ShotModelFiltered maybe?

[khalsz]

May be we can discuss this. to explain to you better.

[khalsz]

it is not necessary just a filter model. It does more than filter.

[khalsz]

After adding the shot filter model. The result of http://localhost:8081/json/shots was Internal Server Error and the error I got on the terminal is:
image
This is because the models created failed to validate with the alias of the fields meanwhile the api gives it result using the alias of the fields.

[NathanCummings]

After adding the shot filter model. The result of http://localhost:8081/json/shots was Internal Server Error and the error I got on the terminal is: image This is because the models created failed to validate with the alias of the fields meanwhile the api gives it result using the alias of the fields.

I'm not seeing the image. I think the markdown needs fixing.

[khalsz]

sorry. Here's the image