Fix native Windows/MSYS2 compatibility - #60
Open
chris241 wants to merge 1 commit into
Open
Conversation
babashka.fs/set-posix-file-permissions throws UnsupportedOperationException on NTFS via native (non-Cygwin) babashka builds; catch it and continue since POSIX permission bits are not meaningful on Windows anyway. handoffd.bb, swarm-window-watchdog.sh, and pack_web.sh were invoked directly as programs relying on their shebang lines. Native Windows process creation does not interpret shebangs, so these now run through an explicit interpreter (bb / zsh) as every other script invocation in this codebase already does. Documents MSYS2 as a native-Windows path (no WSL required) in the README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SwarmForge's runnable path had never been exercised on native Windows before. Running the
two-packworkflow end-to-end on Windows 11 with MSYS2 (zsh + tmux + native Babashka, no WSL) surfaced three concrete bugs, all inmain's sharedswarmforge/scripts/:fs/set-posix-file-permissionsthrowsUnsupportedOperationExceptionon NTFS through a native (non-Cygwin) Babashka build. POSIX permission bits aren't meaningful on Windows, so the call is now wrapped in try/catch and ignored there.handoffd.bb,swarm-window-watchdog.sh, andpack_web.shwere invoked directly as programs, relying on their#!/usr/bin/env ...shebang line. Native Windows process creation does not interpret shebangs (only Cygwin/MSYS2 shells do), so each of these three call sites now runs through an explicit interpreter (bb/zsh) — matching how every other script invocation in this codebase already works (e.g.stop_handoff_daemon.bbis already called asbb ... stop_handoff_daemon.bb).Also documents MSYS2 as a native-Windows install path (no WSL required) in the README, alongside the existing WSL-oriented Windows Terminal notes.
Test plan
claudeCLI on Windows 11.get-swarm-forge two-pack claudethen./swarmfrom an MSYS2 zsh shell against a real project directory.Dashboard: http://127.0.0.1:...), bothcoderandcleanertmux sessions launched, the handoff daemon started, and thecoderrole'sclaudeagent process was invoked correctly inside its tmux pane.UnsupportedOperationException; the interpreter prefixes match the existing pattern used elsewhere in the file).