Skip to content

fix: correct isJSONSerializable to handle null without throwing #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EduardF1 wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −1
Open

fix: correct isJSONSerializable to handle null without throwing #572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0bc8716
fix: correct isJSONSerializable to handle null without throwing
EduardF1 May 4, 2026
a6cf69a
test: cover null JSON serialization
EduardF1 Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export function isJSONSerializable(value: any): boolean {
return false;
}
const t = typeof value;
if (t === "string" || t === "number" || t === "boolean" || t === null) {
if (t === "string" || t === "number" || t === "boolean" || value === null) {
return true;
}
if (t !== "object") {
Expand Down
5 changes: 5 additions & 0 deletions test/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
import { Readable } from "node:stream";
import { H3, HTTPError, readBody, serve } from "h3";
import { $fetch } from "../src/index.ts";
import { isJSONSerializable } from "../src/utils.ts";

describe("ofetch", () => {
let listener: ReturnType<typeof serve>;
Expand Down Expand Up @@ -158,6 +159,10 @@ describe("ofetch", () => {
}
});

it("treats null as JSON serializable", () => {
expect(isJSONSerializable(null)).toBe(true); // eslint-disable-line unicorn/no-null
});

it("does not stringify body when content type != application/json", async () => {
const message = '"Hallo von Pascal"';
const { body } = await $fetch(getURL("echo"), {
Expand Down
Loading