Skip to content

fix: add error logging to AsyncStorage catch blocks #3866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gugli4ifenix-design wants to merge 3 commits into
base: main
Choose a base branch
from
+32 −8
Open

fix: add error logging to AsyncStorage catch blocks #3866

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02c025c
fix: add error logging to AsyncStorage catch blocks
gugli4ifenix-design Apr 25, 2026
12b22a7
fix: use process.env.NODE_ENV instead of __DEV__ for TS compat
gugli4ifenix-design Apr 25, 2026
e112f68
style: format with prettier
gugli4ifenix-design Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 32 additions & 8 deletions packages/storage-rn/src/makeAsyncStorage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ const parseData = (persistedData: any, fallback: any) => {
if (persistedData) {
return JSON.parse(persistedData);
}
} catch (_err) {}
} catch (_err) {
if (process.env.NODE_ENV !== 'production')
console.warn('[urql] AsyncStorage error:', _err);
}

return fallback;
};
Expand Down Expand Up @@ -66,7 +69,10 @@ export const makeAsyncStorage: (
let persistedData: string | null = null;
try {
persistedData = await AsyncStorage.getItem(dataKey);
} catch (_err) {}
} catch (_err) {
if (process.env.NODE_ENV !== 'production')
console.warn('[urql] AsyncStorage error:', _err);
}
const parsed = parseData(persistedData, {});

Object.assign(allData, parsed);
Expand All @@ -84,7 +90,10 @@ export const makeAsyncStorage: (
if (syncNeeded) {
try {
await AsyncStorage.setItem(dataKey, JSON.stringify(allData));
} catch (_err) {}
} catch (_err) {
if (process.env.NODE_ENV !== 'production')
console.warn('[urql] AsyncStorage error:', _err);
}
}

return Object.assign(
Expand All @@ -98,7 +107,10 @@ export const makeAsyncStorage: (
let persistedData: string | null = null;
try {
persistedData = await AsyncStorage.getItem(dataKey);
} catch (_err) {}
} catch (_err) {
if (process.env.NODE_ENV !== 'production')
console.warn('[urql] AsyncStorage error:', _err);
}
const parsed = parseData(persistedData, {});
Object.assign(allData, parsed);
}
Expand All @@ -121,20 +133,29 @@ export const makeAsyncStorage: (

try {
await AsyncStorage.setItem(dataKey, JSON.stringify(allData));
} catch (_err) {}
} catch (_err) {
if (process.env.NODE_ENV !== 'production')
console.warn('[urql] AsyncStorage error:', _err);
}
},

writeMetadata: async data => {
try {
await AsyncStorage.setItem(metadataKey, JSON.stringify(data));
} catch (_err) {}
} catch (_err) {
if (process.env.NODE_ENV !== 'production')
console.warn('[urql] AsyncStorage error:', _err);
}
},

readMetadata: async () => {
let persistedData: string | null = null;
try {
persistedData = await AsyncStorage.getItem(metadataKey);
} catch (_err) {}
} catch (_err) {
if (process.env.NODE_ENV !== 'production')
console.warn('[urql] AsyncStorage error:', _err);
}
return parseData(persistedData, []);
},

Expand All @@ -156,7 +177,10 @@ export const makeAsyncStorage: (
allData = {};
await AsyncStorage.removeItem(dataKey);
await AsyncStorage.removeItem(metadataKey);
} catch (_err) {}
} catch (_err) {
if (process.env.NODE_ENV !== 'production')
console.warn('[urql] AsyncStorage error:', _err);
}
},
};
};
Loading