fix(tests): skip symlink test when Windows lacks privilege#744
Open
pranav-afk wants to merge 2 commits into
Open
fix(tests): skip symlink test when Windows lacks privilege#744pranav-afk wants to merge 2 commits into
pranav-afk wants to merge 2 commits into
Conversation
Contributor
Greptile SummaryThis PR makes the symlink-size test handle Windows privilege limits.
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "fix(tests): only skip symlink test on Wi..." | Re-trigger Greptile |
pranav-afk
force-pushed
the
fix/windows-symlink-test-skip
branch
from
July 13, 2026 11:08
951818f to
9ac12b9
Compare
0xallam
force-pushed
the
main
branch
2 times, most recently
from
July 13, 2026 23:50
44e87ca to
daf39a2
Compare
0xallam
force-pushed
the
fix/windows-symlink-test-skip
branch
from
July 13, 2026 23:51
9ac12b9 to
0a53c2b
Compare
|
This fix looks correct and complete — catches the privilege error, shows a clear message, and re-raises other OSErrors. The production code (directory_size_bytes) already handles symlinks correctly via os.scandir() with follow_symlinks=False, so only the test needed changes. Ship it. 🚀 |
Collaborator
On Windows without Administrator or Developer Mode, Path.symlink_to raises WinError 1314 and crashes the suite. Skip with a clear remediation message instead. Fixes usestrix#650.
Re-raise unrelated OSErrors so setup failures are not hidden as skips.
pranav-afk
force-pushed
the
fix/windows-symlink-test-skip
branch
from
July 15, 2026 07:02
0a53c2b to
a4dc0a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows without Administrator or Developer Mode, Path.symlink_to raises WinError 1314 and crashes the suite. Skip with a clear remediation message instead. Fixes #650.