Skip to content

Only return external output resolver if the input resolver also goes to the external #2804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavyLandman merged 1 commit into from
Jun 17, 2026
+5 −1
Merged

Only return external output resolver if the input resolver also goes to the external #2804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/org/rascalmpl/uri/URIResolverRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,11 @@ private ISourceLocationOutput getOutputResolver(String scheme) {
return result;
}
}
if (externalRegistry != null && externalRegistry.supportsOutput(scheme)) {
// only return an external registry if the input is also going to an external resolver
// as input resolvers are quite common, but output less, and we don't want all of them
// to always go via the external registries (just to receive an exception)
var inputResolver = getInputResolver(scheme);
if (externalRegistry != null && externalRegistry.supportsOutput(scheme) && inputResolver == externalRegistry) {
return externalRegistry;
}
}
Expand Down
Loading