refactor!: remove DataCommunicatorBuilder abstraction#9664
Draft
vursen wants to merge 3 commits into
Draft
Conversation
vursen
added
requires new major
vursen
changed the title
Prepare for Vaadin 26, where DataCommunicatorBuilder will be replaced by a createDataCommunicator() method (#9664). Add createDataCommunicator() now so it's available as an override point already, and deprecate DataCommunicatorBuilder and the constructors that accept it. Existing constructors keep their current behavior unchanged: the builder-based constructors store the given builder and createDataCommunicator() uses it, preserving backward compatibility for anyone with a custom DataCommunicatorBuilder. Related to #9664 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Add getCompositeDataGenerator() alongside the existing getArrayUpdater(), and use it in createDataCommunicator() instead of accessing the private field directly. Rename the backing field from gridDataGenerator to compositeDataGenerator to match its type and the new getter name. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Remove the DataCommunicatorBuilder indirection and the generic <U, B> constructor overloads it required. Grid and TreeGrid now build their DataCommunicator by overriding a simple createDataCommunicator() method instead of passing a builder instance through the constructor chain. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
vursen
force-pushed
the
refactor/grid-data-communicator-builder
branch
from
147fcf5 to
1c19e10
Compare
vursen
changed the base branch from
main
to
deprecate/grid-data-communicator-builder
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the DataCommunicatorBuilder indirection and the generic <U, B> constructor overloads it required. Grid and TreeGrid now build their DataCommunicator by overriding a simple createDataCommunicator() method instead of passing a builder instance through the constructor chain.
Depends on