fix: render grid data when cache is populated before attach#9689
Open
vursen wants to merge 2 commits into
Open
fix: render grid data when cache is populated before attach#9689vursen wants to merge 2 commits into
vursen wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
vursen
changed the title
vursen
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the connector receives data while the grid is still detached from the DOM, for example when a grid is rendered inside another grid's component renderer, there is no data provider call, so nothing sets the grid's
_hasDataproperty. After attaching, the grid then doesn't render the cached rows (the_flatSizeChangedobserver only updates the virtualizer when_hasDatais set) and also sends an unnecessary data request to the server. This change makes the connector set_hasDatawhen resolving pending callbacks, which covers this case since populating the cache always ends with aconfirmcall.Note
The new client-side test also requires vaadin/web-components#12035, which stops the web component from discarding items added to its cache before attach. The test will keep failing until that fix is included in a platform alpha and the version is bumped here.
Fixes #9674