refactor!: merge ColumnBase into AbstractColumn#9698
Open
vursen wants to merge 1 commit into
Open
Conversation
ColumnBase was a package-private interface whose only implementor was AbstractColumn, and all column types reach its methods by extending AbstractColumn. Move its default methods onto AbstractColumn as concrete methods and drop the interface. The public fluent API on Grid.Column and ColumnGroup is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
vursen
changed the title
vursen
added
requires new major
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ColumnBase is a package-private interface whose only implementor is AbstractColumn, and every column type (Grid.Column, ColumnGroup) gets its methods by extending AbstractColumn anyway. The interface adds a level of abstraction for no real benefit, so this PR proposes to merge it into AbstractColumn.
Warning
This change breaks binary compatibility. ColumnBase's fluent setters returned the self type
Twhose bound was ColumnBase, soTerased to ColumnBase in the compiled bytecode. Now the bound is AbstractColumn, so it erases to AbstractColumn. For example,setResizable's descriptor changes from(Z)Lcom/vaadin/flow/component/grid/ColumnBase;to(Z)Lcom/vaadin/flow/component/grid/AbstractColumn;, and since ColumnBase no longer exists, code compiled against the previous version can now fail with NoSuchMethodError until it's recompiled.