This repository was archived by the owner on Apr 12, 2026. It is now read-only.
Adding MacOS aarch64 target#275
Closed
CodingTil wants to merge 2 commits into
Closed
Conversation
Author
|
Duplicate of #230 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the rise of Apple Silicon users, we also see a rise in issues like these: valentjn/vscode-ltex#634
This MR aims to resolve the issue of the missing/incorrect MacOS Java installation that ships with ltex-ls.
First, the Java version was updated (still 11.0) to a version where all targets (os + platform) were available.
Secondly, an archive for mac aarch64 will now also be created.
Unfortunately, the build process already failed for me during Kotlin file compilation (guidance appreciated), but the GitHub workflow seems OK at least (although mac aarch64 is not tested, as it does not seem to be available yet for free GitHub workflows - see here).