Repository navigation
mbp-1005: Implement multi-role support for Vault JWT configuration - #61
Merged
Merged
Conversation
Signed-off-by: Manuel Lorenzo <mlorenzofr@redhat.com>
minmzzhang
added a commit
to minmzzhang/layered-zero-trust
that referenced
this pull request
Nov 14, 2025
Merge PR#69 changes to support multiple Vault JWT roles natively. Changes: 1. Update common/scripts/vault-utils.sh (from validatedpatterns#69) - Simplify to use vault_jwt_roles variable (matches rhvp.cluster_utils v1.1.0) - Remove legacy single-role variables (default_role, spiffe_audience, etc.) - Pass vault_jwt_roles instead of jwt_roles to Ansible 2. Remove vault-role-creator workaround - Delete charts/rhtpa-operator/templates/vault-role-creator-job.yaml - Delete charts/rhtpa-operator/templates/vault-role-creator-script.yaml - No longer needed now that Ansible collection supports multi-role Upstream Dependencies: - rhvp.cluster_utils v1.1.0+ (PR validatedpatterns/rhvp.cluster_utils#61) - Implements vault_jwt_roles loop in vault_jwt_roles.yaml - Creates all JWT roles defined in values-hub.yaml - validatedpatterns/layered-zero-trust PR#69 (vault-utils.sh update) This properly creates all JWT roles (qtodo, rhtpa, syft) via Ansible instead of using the Kubernetes Job workaround. Testing: After installation, verify all roles created: oc exec -n vault vault-0 -- vault list auth/jwt/role # Expected: qtodo, rhtpa, syft Related: validatedpatterns#69 Related: validatedpatterns/rhvp.cluster_utils#61 Signed-off-by: Min Zhang <minzhang@redhat.com>
minmzzhang
added a commit
to minmzzhang/layered-zero-trust
that referenced
this pull request
Nov 15, 2025
Merge PR#69 changes to support multiple Vault JWT roles natively. Changes: 1. Update common/scripts/vault-utils.sh (from validatedpatterns#69) - Simplify to use vault_jwt_roles variable (matches rhvp.cluster_utils v1.1.0) - Remove legacy single-role variables (default_role, spiffe_audience, etc.) - Pass vault_jwt_roles instead of jwt_roles to Ansible 2. Remove vault-role-creator workaround - Delete charts/rhtpa-operator/templates/vault-role-creator-job.yaml - Delete charts/rhtpa-operator/templates/vault-role-creator-script.yaml - No longer needed now that Ansible collection supports multi-role Upstream Dependencies: - rhvp.cluster_utils v1.1.0+ (PR validatedpatterns/rhvp.cluster_utils#61) - Implements vault_jwt_roles loop in vault_jwt_roles.yaml - Creates all JWT roles defined in values-hub.yaml - validatedpatterns/layered-zero-trust PR#69 (vault-utils.sh update) This properly creates all JWT roles (qtodo, rhtpa, syft) via Ansible instead of using the Kubernetes Job workaround. Testing: After installation, verify all roles created: oc exec -n vault vault-0 -- vault list auth/jwt/role # Expected: qtodo, rhtpa, syft Related: validatedpatterns#69 Related: validatedpatterns/rhvp.cluster_utils#61 Signed-off-by: Min Zhang <minzhang@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements support for multiple roles in the Hashicorp Vault JWT configuration.
This only affects JWT and it has no effect on other Vault components.
We need this changes for Zero Trust Validated Pattern.
I have tested it and it works correctly, but I'm open to changes if you find any bugs.