feat(grants): add DELETE /v1/grants/{grantId} for owner-driven revocation - #80
Open
tnunamak wants to merge 1 commit into
Open
feat(grants): add DELETE /v1/grants/{grantId} for owner-driven revocation#80tnunamak wants to merge 1 commit into
tnunamak wants to merge 1 commit into
Conversation
tnunamak
enabled auto-merge (squash)
May 1, 2026 21:28
Codex ReviewFindings
Verification I attempted to run |
tnunamak
force-pushed
the
tim/account-app-owner-auth
branch
from
August 1, 2026 20:59
1ffc9c5 to
48723eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing companion to
POST /v1/grants. Owner can now revoke a grant by id without producing a wallet popup; PS signsGrantRevocationEIP-712 with its delegatedserverSignerand submits to the gateway.Why
Account-app-driven flows (e.g. account.vana.org's account-action revocation UI in PR vana-com/vana-connect#112) need a programmatic revoke path that does not invoke a user wallet popup at revoke time. PS already exposes
POST /v1/grantsfor the create side; this is the symmetric delete side.Behavior
serverOwner, Bearer access token, or dev token — same model asPOST /).GrantRevocation { grantorAddress, grantId }viaserverSigner.signGrantRevocation.gateway.revokeGrant({ grantId, grantorAddress, signature }).{ status: 'revoked', grantId }on success.Tests
serverSignerreturns 500packages/server/src/routes/grants.test.ts— 18 pass / 0 fail.Scope
Single route added. No middleware changes. No changes to existing routes. No client-side changes (gateway client already exposes
revokeGrant).