Skip to content

fix(elements): render empty-string tool output in ToolOutput #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shoemoney wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(elements): render empty-string tool output in ToolOutput #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions packages/elements/__tests__/tool.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,4 +250,40 @@ describe("toolOutput", () => {
);
expect(screen.getByText("Result")).toBeInTheDocument();
});

it("renders empty-string output", () => {
render(
<Tool>
<ToolOutput errorText={undefined} output="" />
</Tool>
);
expect(screen.getByText("Result")).toBeInTheDocument();
});

it("renders zero output", () => {
render(
<Tool>
<ToolOutput errorText={undefined} output={0} />
</Tool>
);
expect(screen.getByText("Result")).toBeInTheDocument();
});

it("renders false output", () => {
render(
<Tool>
<ToolOutput errorText={undefined} output={false} />
</Tool>
);
expect(screen.getByText("Result")).toBeInTheDocument();
});

it("renders nothing when output is null", () => {
const { container } = render(
<Tool>
<ToolOutput errorText={undefined} output={null} />
</Tool>
);
expect(container.textContent).toBe("");
});
});
2 changes: 1 addition & 1 deletion packages/elements/src/tool.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ export const ToolOutput = ({
errorText,
...props
}: ToolOutputProps) => {
if (!(output || errorText)) {
if ((output === undefined || output === null) && !errorText) {
return null;
}

Expand Down