Skip to content

fix(code-block): size line-number gutter to the widest line number #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drPod wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(code-block): size line-number gutter to the widest line number #483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/code-block-line-number-gutter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"ai-elements": patch
---

Size the CodeBlock line-number column to the widest line number instead of a fixed width, so 4+ digit line numbers no longer spill into the code
29 changes: 18 additions & 11 deletions packages/elements/src/code-block.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,11 @@ const TokenSpan = ({ token }: { token: ThemedToken }) => (

// Line number styles using CSS counters
const LINE_NUMBER_CLASSES = cn(
"block",
"contents",
"before:content-[counter(line)]",
"before:inline-block",
"before:[counter-increment:line]",
"before:w-8",
"before:mr-4",
"before:min-w-12",
"before:pr-4",
"before:text-right",
"before:text-muted-foreground/50",
"before:font-mono",
Expand All @@ -97,15 +96,22 @@ const LineSpan = ({
}: {
keyedLine: KeyedLine;
showLineNumbers: boolean;
}) => (
<span className={showLineNumbers ? LINE_NUMBER_CLASSES : "block"}>
{keyedLine.tokens.length === 0
}) => {
const content =
keyedLine.tokens.length === 0
? "\n"
: keyedLine.tokens.map(({ token, key }) => (
<TokenSpan key={key} token={token} />
))}
</span>
);
));

return showLineNumbers ? (
<span className={LINE_NUMBER_CLASSES}>
<span>{content}</span>
</span>
) : (
<span className="block">{content}</span>
);
};

// Types
type CodeBlockProps = HTMLAttributes<HTMLDivElement> & {
Expand Down Expand Up @@ -279,7 +285,8 @@ const CodeBlockBody = memo(
<code
className={cn(
"font-mono text-sm",
showLineNumbers && "[counter-increment:line_0] [counter-reset:line]"
showLineNumbers &&
"grid grid-cols-[max-content_max-content] [counter-increment:line_0] [counter-reset:line]"
)}
>
{keyedLines.map((keyedLine) => (
Expand Down