Skip to content

Remove experimental.useNodeStreams flag as it's enabled#93938

Open
timneutkens wants to merge 1 commit into
canaryfrom
codex/node-streams-always-on
Open

Remove experimental.useNodeStreams flag as it's enabled#93938
timneutkens wants to merge 1 commit into
canaryfrom
codex/node-streams-always-on

Conversation

@timneutkens
Copy link
Copy Markdown
Contributor

@timneutkens timneutkens commented May 19, 2026

What?

Remove experimental.useNodeStreams from the public config surface and make Node streams always-on for Node.js App Router rendering.

The smaller default-on change and dedicated CI cleanup landed in #94311. The standalone compatibility update landed separately in #94347.

Why?

Node streams are now the default Node.js runtime rendering path, so the opt-in config and runtime selection plumbing are stale. Edge bundles continue to use the web-stream path because Node streams are unavailable there.

How?

  • Define __NEXT_USE_NODE_STREAMS as true for Node.js app runtime bundles and false for edge user bundles.
  • Remove config, schema, runtime, export, and server plumbing for experimental.useNodeStreams.
  • Delete the obsolete env-precedence fixture.
  • Clean benchmark docs and scripts that still set or compare experimental.useNodeStreams.

Verification

  • pnpm --filter=next types
  • pnpm build-all

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

Tests Passed

Commit: 95ef513

@timneutkens timneutkens force-pushed the codex/node-streams-always-on branch from 62c12c5 to ef72214 Compare May 19, 2026 14:00
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

Stats cancelled

Commit: 95ef513
View workflow run

@timneutkens timneutkens changed the title Make Node streams always on Make Node.js streams always on May 21, 2026
@timneutkens timneutkens marked this pull request as ready for review May 22, 2026 11:04
@timneutkens timneutkens force-pushed the codex/node-streams-always-on branch from af71def to 5a21522 Compare May 22, 2026 11:34
@timneutkens timneutkens force-pushed the codex/node-streams-always-on branch 3 times, most recently from 890a7bb to 25fd1f0 Compare June 3, 2026 13:12
@timneutkens timneutkens force-pushed the codex/node-streams-always-on branch from 25fd1f0 to 95ef513 Compare June 3, 2026 13:16
@timneutkens timneutkens requested a review from unstubbable June 5, 2026 12:37
@timneutkens timneutkens changed the title Make Node.js streams always on Remove experimental.useNodeStreams flag as it's enabled Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant