fix: avoid /index cache-key collision for root dynamic routes#94326
Open
YoussefMansour9 wants to merge 2 commits into
Open
fix: avoid /index cache-key collision for root dynamic routes#94326YoussefMansour9 wants to merge 2 commits into
YoussefMansour9 wants to merge 2 commits into
Conversation
When a root-level dynamic route (e.g., [slug] with dynamicParams: true) coexists with / and the / page has a stale ISR cache, a request to /index is handled by [slug] but its resolvedPathname is normalized to /, causing the ISR cache key (ssgCacheKey) to collide with the / page. The [slug] notFound() result then overwrites the / page's cache, making / permanently return 404. This extracts the /index to / normalization into normalizeResolvedPathname() and adds a guard: the normalization is skipped when normalizedSrcPage is a dynamic route, keeping the cache key as /index and avoiding the collision. Fixes vercel#92296
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Additional Suggestions:
- app-route.ts re-normalizes the ISR cache key (/index -> /) unconditionally, undoing the prepare() fix that preserves /index for root dynamic route handlers and re-introducing the cache-key collision with the / page.
- Unconditional cacheKey normalization in pages-handler.ts collapses /index back to /, re-introducing the ISR cache-key collision the PR fixes for root dynamic pages routes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a root-level dynamic route (e.g., [slug] with dynamicParams: true) coexists with / and the / page has a stale ISR cache, a request to /index is handled by [slug] but its resolvedPathname is normalized to /, causing the ISR cache key (ssgCacheKey) to collide with the / page. The [slug] notFound() result then overwrites the / page cache, making / permanently return 404.
This extracts the /index to / normalization into normalizeResolvedPathname() and adds a guard: the normalization is skipped when normalizedSrcPage is a dynamic route, keeping the cache key as /index and avoiding the collision.
Fixes #92296