Skip to content

Fix the double users showing in results #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robmackenzie merged 2 commits into from
Jul 30, 2025
Merged

Fix the double users showing in results #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa3b2f2
Added in a quick dedupe of the list of dicts returned from the pagina…
Jul 30, 2025
58aa9c5
Fixed the name of the forum software in a comment
Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion libs/discourse_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,12 @@ def get_all_voters(self, post_id, poll_name, option_id):

# No more pages; we're done.
if r["voters"] is None:
return results
# Need to do a quick simple de-dupe due to a bug in the pagination from Discourse
deduped_list=[]
for user in results:
if user not in deduped_list:

@EricNelson12 EricNelson12 Jul 30, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the type of user? if it's a reference to a class or dict or something then the user not in deduped_list might not work as it appears to if the same user has had two difference instances made. BUT I'm assuming it's a string with their username, in which case this should be good 😄

@EricNelson12 EricNelson12 Jul 30, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And if they are just strings, then can we go list(set(users)) to de-dup?

@robmackenzie robmackenzie Jul 30, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User is a dict. results is a list of those dicts.

NB: we discussed this in slack

deduped_list.append(user)
return deduped_list

results += r["voters"][option_id]

Expand Down