Repository navigation
ci: run the tests on the image's Python too - #14
Merged
Merged
Conversation
.python-version pins the oldest supported Python (3.13), so the checks only ever ran the suite there, while the image is built from the newest Python. A Dependabot bump of the base image was therefore built, but not tested. The checks now read the version from the Dockerfile's FROM line and run pytest on it as well, so such a bump is tested on the PR itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.python-versionpins the oldest supported Python (3.13), so the checks only ever ran the test suite there, while the image is built from the newest Python (3.15 since #5). A Dependabot bump of the base image was therefore built, but never tested.The checks now read the Python version from the Dockerfile's
FROM python:line and run pytest on it as well, so a base-image bump is tested on the PR itself, without anyone maintaining a version matrix.Verified by running the exact step inside
python:3.15-slim: the version derives as 3.15 despite.python-version, and the suite passes on 3.15.2. Note that the locked pyyaml 6.0.3 has no 3.15 wheels yet (PyPI has nothing newer), so on 3.15 uv builds it from source. The image build has been doing the same since #5; the step takes a few seconds extra.🤖 Generated with Claude Code