Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 6, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
async-servicestructure visualization) https://gist.github.com/hi-ogawa/e07023a1f086bb96f948bfb9c30d249dNo app awaits in its tests.
cpu-boundandnode-backendare fully synchronous, so a change that costs something per promise in the test worker, such asAsyncLocalStorageon Node 22, doesn't show up in any of them.This adds
async-service: node-backend's shape (repos, domain services, CRUD tests) with every layer async. A driver checks out a pooled connection, repos query through it, and services validate, write an audit row and fan out withPromise.all. It has 64 test files of 3 tests each, and each test awaits tens of thousands of promises, so a default run spends most of its time in the tests rather than in startup. It has no dependencies, so module loading stays small. The default matrix runs forks and threads withisolateon and off.vitest main vs vitest-dev/vitest#11887
Setup:
71ad4dfa1and the #11887 head at5726e0a6e, each linked into the app'snode_modules/vitest.isolate: true, defaultmaxWorkers.vitest run, median of 8 runs after one untimed priming run, with the four Node and build cells interleaved.The sync apps don't move on either Node version. On Node 22,
async-serviceis 38% slower with #11887, and the runs don't overlap (3.32–3.61 s vs 4.64–5.03 s). On Node 24 it's within noise (2.89–3.20 s vs 2.74–3.29 s). That matches how the two versions implementAsyncLocalStorage: Node 22 runs promise hooks on every promise, while Node 24 builds it onAsyncContextFrame.