fix: preserve UTF-8 encoding in comment parsing#208
Open
2catycm wants to merge 1 commit into
Open
Conversation
In parse_comment(), iterating `for c in str` yields u8 bytes. Calling write_rune(c) re-encodes each byte as a Unicode code point, corrupting multi-byte UTF-8 characters (e.g. Chinese comments become garbled). Use write_u8(c) instead to pass bytes through unchanged. Fixes comment corruption for all non-ASCII source files.
Contributor
|
Perhaps simpler would be to change to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
In
parse_comment(),for c in striterates over bytes (u8). The subsequentcomment.write_rune(c)treats each byte as a Unicode code point and re-encodes it as UTF-8, causing multi-byte characters to be double-encoded.For example,
你(UTF-8:[0xE4, 0xBD, 0xA0]) becomesä½because each byte gets individually re-encoded as a 2-byte UTF-8 sequence.Fix
Replace
write_rune(c)withwrite_u8(c)at all 4 call sites inparse_comment(). Since we're iterating bytes and want to preserve them as-is,write_u8is the correct method.Testing