Skip to content

fix BLE write limits#60

Open
positron96 wants to merge 1 commit into
vshymanskyy:mainfrom
positron96:main
Open

fix BLE write limits#60
positron96 wants to merge 1 commit into
vshymanskyy:mainfrom
positron96:main

Conversation

@positron96

Copy link
Copy Markdown

Fixes #57

Fixes 2 issues:

  • WebBluetooth transport had tx_limit which were not used in any way, parent Transport used its own writeChunk. Now WebBluetooth transport updates parent field, which causes transmissions to split data properly.
  • For Nordic UART Service, tx_limit was 241, when all of Nordic Semi builds of micropython have max characteristic size of 20. It's possible that other builds (e.g. ESP32) have a larger characteristic, but it can't be relied upon anyway. It's set to 20 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ViperIDE does not connect to wasp-os on PineTime over BLE

1 participant